imx6ull: configuration changes to multiple drivers #611
Conversation
Add option to configure mux and input selection settings at compile time. Set previous settings as defaults for backwards compatibility. JIRA: SEN-40
Add option to configure mux and input selection settings at compile time. Set previous settings as defaults for backwards compatibility. Add option to start in DTE mode (swap TX and RX signals). JIRA: SEN-40
JIRA: SEN-40
Add option to configure mux and input selection settings at compile time. Set previous settings as defaults for backwards compatibility. Add option for a mux to not be configured. JIRA: SEN-40
Summary of ChangesHello @jmaksymowicz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the flexibility of peripheral pin configurations for I2C, UART, and SPI drivers on the i.MX6ULL platform. By externalizing pin multiplexing and input selection settings into compile-time configurable macros, developers can now easily adapt these drivers to various hardware layouts without modifying core driver logic. Additionally, the UART driver gains a new DTE mode, offering more versatile serial communication options. These changes aim to improve maintainability and adaptability of the board support package. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces valuable compile-time configuration options for I2C, UART, and SPI peripheral pins, enhancing the flexibility of the drivers. It also adds support for DTE mode in the UART driver. The changes are well-implemented, including the use of static const for read-only data, which improves code quality. My review includes one suggestion to reduce code duplication by moving common macros to a shared header.
| #define XCAT2(a, b) a##b | ||
| #define PCTL(x) XCAT2(pctl_, x) |
There was a problem hiding this comment.
These helper macros (XCAT2, PCTL) are also defined in libecspi.c and imx6ull-uart.c. To avoid code duplication and improve maintainability, consider moving them to a common header file, for example a new platform utilities header or an existing one like <phoenix/arch/armv7a/imx6ull/imx6ull.h>.
Unit Test Results8 541 tests - 921 8 015 ✅ - 858 49m 42s ⏱️ - 1m 23s For more details on these failures, see this check. Results for commit 7e36d63. ± Comparison against base commit 630b3e1. This pull request removes 921 tests. |
Description
For I2C, UART and SPI drivers MUX and ISEL configuration options were added so that signal pins of these peripherals can be redefined at compile time. Additionally, UART driver was updated to support DTE mode in which TX and RX pins are swapped.
clang-format was applied to
imx6ull-ecspicode in a separate commit to make it clear which changes are just formatting and which change the program's logic.Motivation and Context
JIRA: SEN-40
Types of changes
How Has This Been Tested?
Checklist:
Special treatment