-
Notifications
You must be signed in to change notification settings - Fork 14
Add coredump server to -multi devices #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @etiaro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a built-in coredump server to the imxrt-multi and stm32l4-multi projects. This enhancement allows for the capture and saving of coredumps, which are crucial for post-mortem debugging of crashes in embedded systems. The changes integrate the coredump server as a new thread within the main application, providing a mechanism to configure and enable/disable this functionality during compilation.
Highlights
- Coredump Server Integration: A new coredumpsrv.c file is added for both imxrt-multi and stm32l4-multi targets, implementing a dedicated thread (coredumpsrv_thr) that initializes and runs the libcoredumpsrv server.
- Build System Updates: Makefiles for both imxrt-multi and stm32l4-multi are modified to include the new coredumpsrv.c source file and link against the libcoredumpsrv library, ensuring the coredump server is part of the build.
- Configurable Coredump Feature: Configuration headers (config.h) and Makefiles are updated to introduce BUILTIN_COREDUMPSRV and COREDUMP_DISABLE macros, allowing the coredump server to be conditionally compiled and enabled/disabled.
- Application Startup Integration: The main functions in imxrt-multi.c and stm32l4-multi.c are updated to conditionally start the coredumpsrv_start() function, ensuring the coredump server thread is launched when the application begins.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a coredump server for both imxrt-multi and stm32l4-multi. The changes are generally good, but there's a significant amount of code duplication with the new coredumpsrv.c files. My review includes suggestions to refactor this into a shared component, make the file-scope variables static, allow for configuration of coredump options, and simplify some preprocessor logic for better consistency and maintainability.
3f76abe to
d39a381
Compare
d39a381 to
cec2645
Compare
cec2645 to
1463a7e
Compare
Save target memory by including libcoredumpsrv in stm32l4-multi instead of standalone executable. JIRA: RTOS-1054
Save target memory by including libcoredumpsrv in imxrt-multi instead of standalone executable. JIRA: RTOS-1054
1463a7e to
b275ce4
Compare
Description
Adds optional builin coredump server in -multi devices in order to allow including in -multi devices to save memory on imxrt and stm32l4, similar to posixsrv and dummyfs.
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment