Skip to content

Conversation

@etiaro
Copy link

@etiaro etiaro commented Aug 28, 2025

Description

Adds optional builin coredump server in -multi devices in order to allow including in -multi devices to save memory on imxrt and stm32l4, similar to posixsrv and dummyfs.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7m7-imxrt117x-evk

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @etiaro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a built-in coredump server to the imxrt-multi and stm32l4-multi projects. This enhancement allows for the capture and saving of coredumps, which are crucial for post-mortem debugging of crashes in embedded systems. The changes integrate the coredump server as a new thread within the main application, providing a mechanism to configure and enable/disable this functionality during compilation.

Highlights

  • Coredump Server Integration: A new coredumpsrv.c file is added for both imxrt-multi and stm32l4-multi targets, implementing a dedicated thread (coredumpsrv_thr) that initializes and runs the libcoredumpsrv server.
  • Build System Updates: Makefiles for both imxrt-multi and stm32l4-multi are modified to include the new coredumpsrv.c source file and link against the libcoredumpsrv library, ensuring the coredump server is part of the build.
  • Configurable Coredump Feature: Configuration headers (config.h) and Makefiles are updated to introduce BUILTIN_COREDUMPSRV and COREDUMP_DISABLE macros, allowing the coredump server to be conditionally compiled and enabled/disabled.
  • Application Startup Integration: The main functions in imxrt-multi.c and stm32l4-multi.c are updated to conditionally start the coredumpsrv_start() function, ensuring the coredump server thread is launched when the application begins.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a coredump server for both imxrt-multi and stm32l4-multi. The changes are generally good, but there's a significant amount of code duplication with the new coredumpsrv.c files. My review includes suggestions to refactor this into a shared component, make the file-scope variables static, allow for configuration of coredump options, and simplify some preprocessor logic for better consistency and maintainability.

@etiaro etiaro changed the title Etiaro/coredumpsrv multi Add coredump server to -multi devices Aug 28, 2025
@etiaro etiaro force-pushed the etiaro/coredumpsrv-multi branch 2 times, most recently from 3f76abe to d39a381 Compare August 28, 2025 14:27
@etiaro etiaro force-pushed the etiaro/coredumpsrv-multi branch from d39a381 to cec2645 Compare October 20, 2025 15:59
@etiaro etiaro force-pushed the etiaro/coredumpsrv-multi branch from cec2645 to 1463a7e Compare November 4, 2025 15:59
Save target memory by including libcoredumpsrv in stm32l4-multi instead of standalone executable.

JIRA: RTOS-1054
Save target memory by including libcoredumpsrv in imxrt-multi instead of standalone executable.

JIRA: RTOS-1054
@etiaro etiaro force-pushed the etiaro/coredumpsrv-multi branch from 1463a7e to b275ce4 Compare November 5, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants