Skip to content

[DO NOT MERGE] Introduce coredump server #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
etiaro wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[DO NOT MERGE] Introduce coredump server #1370

etiaro wants to merge 2 commits into from

Conversation

@etiaro
Copy link
Contributor

@etiaro etiaro commented Aug 12, 2025 •
edited
Loading

Description

phoenix-rtos/phoenix-rtos-kernel#682
phoenix-rtos/phoenix-rtos-utils#242
phoenix-rtos/phoenix-rtos-corelibs#57
phoenix-rtos/phoenix-rtos-devices#575

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 12, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @etiaro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a coredump server by integrating it into the boot process of a wide array of embedded projects and targets. The primary goal is to enable robust debugging capabilities by ensuring that coredumps can be generated and collected when system failures occur across different hardware platforms. This change also includes updates to several key submodules, which are likely prerequisites for the coredump server's functionality.

Highlights

  • Widespread Coredump Server Integration: The coredump_server application has been integrated into the boot configuration files (user.plo.yaml) for numerous projects and targets. This ensures that the coredump server is launched as part of the system's startup sequence across various embedded platforms.
  • Submodule Updates: Several core submodules, including libphoenix, phoenix-rtos-kernel, phoenix-rtos-tests, and phoenix-rtos-utils, have been updated to their latest commits. These updates likely provide the necessary underlying support and functionality for the newly introduced coredump server.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 12, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the coredump_server application across a wide range of projects and targets, which is a valuable feature for debugging. The changes also include updates to several submodules, likely to support this new functionality.

The implementation is mostly consistent, but I've found a few configuration files where the coredump_server is started after the psh application. To ensure that crashes in psh can be captured, the coredump server should be initialized before it. I've left specific comments with suggestions to correct the startup order in the affected files.

@etiaro etiaro force-pushed the etiaro/coredump-server branch 2 times, most recently from cfafd73 to 807aff5 Compare August 12, 2025 16:06
@github-actions
Copy link

github-actions bot commented Aug 13, 2025 •
edited
Loading

Unit Test Results

9 612 tests  +167   9 011 ✅ +155   51m 51s ⏱️ + 3m 52s
  544 suites  -   1     601 💤 + 12 
    1 files   ±  0       0 ❌ ±  0 

Results for commit 4963991. ± Comparison against base commit d388507.

This pull request removes 3 and adds 170 tests. Note that renamed tests count towards both. 
phoenix-rtos-tests/waitpid/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/waitpid/unit.test_waitpid.waitpid_other_zombie
phoenix-rtos-tests/waitpid/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/waitpid/unit.test_waitpid.waitpid_other_zombie_before
phoenix-rtos-tests/waitpid/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/waitpid/unit.test_waitpid.waitpid_wnohang

phoenix-rtos-tests/libc/pthread ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ host-generic-pc:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ ia32-generic-qemu:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
phoenix-rtos-tests/libc/pthread ‑ riscv64-generic-qemu:phoenix-rtos-tests/libc/pthread.test_pthread_cleanup.pthread_cleanup_push_pthread_cancel
…

♻️ This comment has been updated with latest results.

@etiaro etiaro force-pushed the etiaro/coredump-server branch 3 times, most recently from d7c9582 to 0d285e4 Compare August 19, 2025 07:34
@etiaro etiaro force-pushed the etiaro/coredump-server branch 4 times, most recently from 321c18c to dba8b34 Compare August 21, 2025 14:46
@etiaro etiaro force-pushed the etiaro/coredump-server branch 6 times, most recently from 8efdeba to be5701c Compare August 29, 2025 10:45
@etiaro etiaro force-pushed the etiaro/coredump-server branch from be5701c to 8f140c8 Compare October 20, 2025 16:11
etiaro added 2 commits November 5, 2025 11:21
@etiaro
Update submodules
e877a13
@etiaro
build: add coredump_servers to all targets
4963991 
Adds coredump_server to user.plo.yaml of all targets which don't include it in multi devs
Disable Coredump functionality from multi devs by default

JIRA: RTOS-1054
@etiaro etiaro force-pushed the etiaro/coredump-server branch from 8f140c8 to 4963991 Compare November 5, 2025 10:28
@etiaro etiaro changed the title Introduce coredump server [DO NOT MERGE] Introduce coredump server Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@etiaro