Skip to content

filtering protocols when creating a new method in debugger #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: Pharo14
Choose a base branch
from
Open

filtering protocols when creating a new method in debugger #1254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/NewTools-Debugger/StDebuggerMethodImplementorPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,14 @@ StDebuggerMethodImplementorPresenter >> addProtocolsFrom: aClassOrTrait [
(aClassOrTrait isTrait
ifTrue: [ aClassOrTrait protocols ]
ifFalse: [
(aClassOrTrait withAllSuperclasses copyWithoutAll: {
Object.
ProtoObject }) flatCollect: #protocols ]) do: [ :protocol |
(aClassOrTrait withAllSuperclasses copyWithoutAll: {
Object.
ProtoObject.
Class.
Behavior.
ClassDescription.
Object class.
ProtoObject class }) flatCollect: #protocols ]) do: [ :protocol |
Comment on lines +60 to +67
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the class of trait is directly one of those class, we should not filter its protocols.

IMO we should have the protocols of aClassOrTrait and of all its superclasses that are not in this list.

The problem is that is the class is one of those, we will have nothing suggested at all

allProtocolsWithDuplicates at: protocol name put: protocol ].
self addProtocols: allProtocolsWithDuplicates values
]
Expand Down
Loading