filtering protocols when creating a new method in debugger #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jecisc
requested changes
Sep 26, 2025
Comment on lines
+60
to
+67
| (aClassOrTrait withAllSuperclasses copyWithoutAll: { | ||
| Object. | ||
| ProtoObject. | ||
| Class. | ||
| Behavior. | ||
| ClassDescription. | ||
| Object class. | ||
| ProtoObject class }) flatCollect: #protocols ]) do: [ :protocol | |
There was a problem hiding this comment.
If the class of trait is directly one of those class, we should not filter its protocols.
IMO we should have the protocols of aClassOrTrait and of all its superclasses that are not in this list.
The problem is that is the class is one of those, we will have nothing suggested at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrained added protocol names when creating a new class-side method in the debugger.
fix #1207
@Julesboul @DurieuxPol