-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Refactor Visualisation Tab #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, good job in general, must have taken a lot of effort to get that together! The UI looks quite nice, my only suggestion would be to maybe try and work a bit with the widths of different elements (the drag-and-drop, buttons etc) to make it a bit more tight.
I also have some points of discussion, mainly in terms of code style and format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have approved the PR, code looks good, great work! I have left some minor nitpicks, but I consider them non-blocking.
Might be also worth adding some logs to better trace what is going on in the application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Issue
Closes #127
Description
With the introduction of the TLGs tab, the Outputs section now is no longer required for reporting but rather for enhanced data visualisation. We want to change the layout so it is better for visualisation.
Definition of Done
How to test
Check visualisation tab layout
Contributor checklist
Notes to reviewer
The plan is to reformat this section using bslib, which will then need to be implemented across the rest of the app. Refactoring of the Data section is being covered by #140