Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add woff2 extention to directly served static files #255

Closed
wants to merge 4 commits into from
Closed

Add woff2 extention to directly served static files #255

wants to merge 4 commits into from

Conversation

iryston
Copy link
Contributor

@iryston iryston commented Jul 23, 2016

This commit fixes fonts loading problems in certain configurations.

iryston added 4 commits July 23, 2016 08:21
Add woff2 extention to directly served static files
Add woff2 extention to directly served static files
Add woff2 extention to directly served static files
Add woff2 extention to directly served static files
@kkomelin
Copy link
Contributor

I met this issue with Glyphicon icon font, which is included in some versions of Bootstrap framework by default.

@iryston
Copy link
Contributor Author

iryston commented Jul 25, 2016

@kkomelin I had issues with Font Awesome and Google icons too.

@kkomelin
Copy link
Contributor

So I vote for this PR

@iryston
Copy link
Contributor Author

iryston commented Jul 25, 2016

Thanks!

@kkomelin
Copy link
Contributor

@perusio Could you please take a look at this PR when you have time. Thanks.

@pprishchepa
Copy link
Contributor

@iryston What about woff2 in mime.types? It's only woff there.

@kkomelin
Copy link
Contributor

Good point @PavelPrischepa

@iryston
Copy link
Contributor Author

iryston commented Jul 27, 2016

@PavelPrischepa thank you for PR! I want to pay attention that according to w3c recommendation WOFF 2.0 is an improvement on WOFF 1.0. The two formats have different Internet Media Types and may be used in parallel.
So, WOFF2 mime type should be

application/font-woff2                 woff2;

perusio added a commit that referenced this pull request Jul 27, 2016
@perusio
Copy link
Owner

perusio commented Jul 27, 2016

@iryston I committed support for woff2 using woff2? instead of another option in the group.
Thanks for your PR.
747fc30

@perusio perusio closed this Jul 27, 2016
@iryston iryston deleted the woff2 branch July 27, 2016 18:17
@iryston
Copy link
Contributor Author

iryston commented Jul 27, 2016

@perusio thanks for your commit.

jakobg added a commit to codewhisper/drupal-with-nginx that referenced this pull request May 22, 2017
…o D7

* 'D7' of https://github.com/perusio/drupal-with-nginx:
  * Added woff2 support from PR perusio#255 by @iryston.
  Added an appropriate mime type for .woff2
  * Fix perusio#251 with PR from @kkomelin.
  * Include PR#11 from @kkomelin about CGI var vuln.
  Allowed "Well-Known URIs".
  Cache valid responses for 15s.
  disable access_log in php_fpm_status_vhost
  * Disabled SSL v3.
  * Enable OCSP stapling verification.
  Update fastcgi_cache_key
  Issue perusio#212 by colans: Move header-adding to nginx.conf to avoid losing headers.
  Disabled SSLv3 to fix POODLE vulnerability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants