Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an appropriate mime type for .woff2 #257

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Added an appropriate mime type for .woff2 #257

merged 1 commit into from
Jul 27, 2016

Conversation

pprishchepa
Copy link
Contributor

@pprishchepa pprishchepa commented Jul 27, 2016

Related PR #255.

@iryston
Copy link
Contributor

iryston commented Jul 27, 2016

@PavelPrischepa thank you for PR! I want to pay attention that according to w3c recommendation WOFF 2.0 is an improvement on WOFF 1.0. The two formats have different Internet Media Types and may be used in parallel.
So, WOFF2 mime type should be

application/font-woff2                 woff2;

@pprishchepa
Copy link
Contributor Author

@iryston Thank you for the remark. But I'm not sure, Is there any way to change the PR, or do I need to create a new one?

@iryston
Copy link
Contributor

iryston commented Jul 27, 2016

To update a PR, even if you have removed the original remote branch out of which the PR was created, you just need to:

  • Fetch the PR (git fetch pull/<id>/head:branchname and git checkout branchname).
  • Add new commits, amend, rebase, do whatever you like.
  • Push or push force (git push remote +branch).

And after that the PR will be automagically updated

@perusio perusio merged commit 1325e31 into perusio:D7 Jul 27, 2016
@perusio
Copy link
Owner

perusio commented Jul 27, 2016

  • Thanks.

@iryston
Copy link
Contributor

iryston commented Jul 27, 2016

@perusio can you change
application/font-woff woff2;
to
application/font-woff2 woff2;
or it will be better to make a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants