Format libjalali files and add CONTRIBUTION.md #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davoodeh
force-pushed
the
format-libjalali
branch
from
1e1dc8c to
0a10c6f
Compare
Collaborator
|
I wanted to do this a long time ago. The problem was it changes the files in a way that tracking the history can be a little problematic if you just go for a blame :) but I guess it is ok, and if it should be done, lets do it and get on with it, |
Author
|
Okay then, so Since literally "I am to blame," I'll just format everything related in the project and make another PR. Thank you, it's a pain to develop on not-auto-formatted codebases. |
This was referenced Apr 5, 2025
Davoodeh
added a commit
to Davoodeh/jcal_c
that referenced
this pull request
Apr 25, 2025
This action, triggered on push or pull, fails if clang-format fails. This addresses the comment referenced by [1] on persiancal#28 (formatting all the sources following the minimal path examples on persiancal#23). Note that the "sources" directory is hardcoded on the action file pushed. Assuming the change of source directory is a fundamental change with a lot of considerations, no documentations were added to mention that the value used in this file must be synchronized with the directory name on the tree. Suppose this comment suffices. [1]: persiancal#28 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes but style.
Ideally, I suppose every editor is configured to be format-on-save. This change is a vital change for such configurations before people of those type can contribute. I may also make an
.editorconfigfile compatible with this.This serves as an example, discussions are to have about what format to use (
indentis another candidate, having tested both,clang-format --style=gnureally takes the cake with the default no-tabs and formatting macros and sometimes comments).