Remove getopt dependency from ./autogen.sh
#22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davoodeh
changed the title
getopt dependencygetopt dependency from ./autogen.sh
Author
|
Closing in favor of #25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also suggest a change in behavior in favor of a cleaner parsing.
In my opinion it's okay to ignore
-hin favor of other flags (meaning ignore help if after a valid flag like-c).In that case, removing the second
if [ CLEAN ]; clean & exitcan happen and be replaced by a simple-c) clean && exit 0 ;;in the flag loop.Moreover,
alternativeis not descriptive, I suggest adding--no-autoreconfto the flag list for that option.