Skip to content

FISH-12784 update faces dependabot rule #7929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abdulrahim458 merged 4 commits into from
Feb 12, 2026
Merged

FISH-12784 update faces dependabot rule #7929

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd056a3
FISH-12784 update faces dependabot rule
abdulrahim458 Feb 4, 2026
14da74b
FISH-12784 update exclude path rule
abdulrahim458 Feb 6, 2026
3e9c6a3
FISH-12784 update dependabot rule
abdulrahim458 Feb 9, 2026
1f3cee2
FISH-12784 update dependabot rule
abdulrahim458 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ updates:
update-types: ["version-update:semver-major"]
- dependency-name: "org.glassfish.mq:mq-client"
update-types: [ "version-update:semver-major" ]
- dependency-name: "org.glassfish:jakarta.faces"
update-types: ["version-update:semver-major"]
- dependency-name: "org.glassfish.soteria:soteria"
update-types: ["version-update:semver-major"]
Comment on lines 50 to 51
Copy link
Member

@Pandrex247 Pandrex247 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to remove this rule

- dependency-name: "org.glassfish.soteria:soteria.spi.bean.decorator.weld"
Expand Down Expand Up @@ -157,3 +155,11 @@ updates:
update-types: ["version-update:semver-major"]
- dependency-name: "org.jboss.weld.environment:weld-environment-common"
update-types: ["version-update:semver-major"]

# jakarta.faces is intentionally pinned for bundled JSF tests and must not be updated by Dependabot.
- dependency-name: "org.glassfish:jakarta.faces"
dependency-type: "direct"
update-types:
- "version-update:semver-major"
- "version-update:semver-minor"
- "version-update:semver-patch"
Copy link
Member

@Pandrex247 Pandrex247 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this fully exclude this dependency?
We don't want to exclude dependabot from upgrading the "real" dependency - we only want it to exclude this specific test dependency which is intentionally configured to be an older version.