-
Notifications
You must be signed in to change notification settings - Fork 316
FISH-12784 update faces dependabot rule #7929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: FISH-12784-update-faces-dependabot-rule
Are you sure you want to change the base?
FISH-12784 update faces dependabot rule #7929
Conversation
breakponchito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.github/dependabot.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this fully exclude this dependency?
We don't want to exclude dependabot from upgrading the "real" dependency - we only want it to exclude this specific test dependency which is intentionally configured to be an older version.
Pandrex247
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to remove this rule
Description
Important Info
Blockers
Testing
New tests
Testing Performed
Testing Environment
Documentation
Notes for Reviewers