Skip to content

FISH-11137 Add warlibs support to add-library command. #7392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Viii3 merged 3 commits into from
May 23, 2025
Merged

FISH-11137 Add warlibs support to add-library command. #7392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
379ec7f
FISH-11137: Add warlibs support to add-library.
Viii3 May 21, 2025
1b3c743
Update copyright
Pandrex247 May 23, 2025
f9d52fe
FISH-11137 Missed war option
Pandrex247 May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions nucleus/deployment/admin/src/main/java/org/glassfish/deployment/admin/AddLibraryCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
* only if the new code is made subject to such option by the copyright
* holder.
*
* Portions Copyright 2017-2022 Payara Foundation and/or affiliates
* Portions Copyright 2017-2025 Payara Foundation and/or affiliates
*/

package org.glassfish.deployment.admin;
Expand Down Expand Up @@ -96,7 +96,7 @@ public class AddLibraryCommand implements AdminCommand {
@Param(primary=true, multiple=true)
File[] files = null;

@Param(optional=true, acceptableValues="common, app")
@Param(optional=true, acceptableValues="common, app, war")
String type = "common";

@Inject
Expand Down Expand Up @@ -124,6 +124,9 @@ public void execute(AdminCommandContext context) {
if (type.equals("app")) {
libDir = new File(libDir, "applibs");
}
else if (type.equals("war")) {
libDir = new File(libDir, "warlibs");
}

// rename or copy the library file to the appropriate
// library directory
Expand Down
6 changes: 5 additions & 1 deletion nucleus/deployment/admin/src/main/manpages/org/glassfish/deployment/admin/add-library.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ NAME
add-library - adds one or more library JAR files to GlassFish Server

SYNOPSIS
add-library [--help] [--type={common|ext|app}] [--upload={false|true}]
add-library [--help] [--type={common|ext|app|war}] [--upload={false|true}]

library-file-path [library-file-path ... ]

Expand Down Expand Up @@ -56,6 +56,10 @@ OPTIONS
Adds the library files to the application-specific class loader
directory, domain-dir/lib/applibs.

war
Adds the library files to the war-packaged class loader directory,
domain-dir/lib/warlibs.

For more information about these directories, see "Class Loaders"
in Oracle GlassFish Server Application Development Guide.

Expand Down