FISH-11137 Add warlibs support to add-library command.#7392
Merged
Viii3 merged 3 commits intopayara:mainfrom May 23, 2025
Merged
FISH-11137 Add warlibs support to add-library command.#7392Viii3 merged 3 commits intopayara:mainfrom
Viii3 merged 3 commits intopayara:mainfrom
Conversation
lprimak
approved these changes
May 22, 2025
Pandrex247
reviewed
May 23, 2025
Member
Pandrex247
left a comment
Pandrex247
left a comment
There was a problem hiding this comment.
Copyright on the asadmin command needs updating but otherwise LGTM
nucleus/deployment/admin/src/main/java/org/glassfish/deployment/admin/AddLibraryCommand.java
Show resolved
Hide resolved
Pandrex247
approved these changes
May 23, 2025
Member
|
I have updated my docs PR: payara/Payara-Documentation#598 |
Pandrex247
approved these changes
May 23, 2025
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Jun 2, 2025
FISH-11137 Add warlibs support to add-library command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Important Info
Blockers
Testing
New tests
Testing Performed
asadmin add-library --type=war <filename>for the example library.Testing Environment
Maven version: 3.9.6
Java version: 21.0.3, vendor: Eclipse Adoptium
Default locale: en_GB, platform encoding: UTF-8
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"
Documentation
Notes for Reviewers