fix(react-templates): fix TypeaheadSelect state synchronization issue #12147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The closeMenu() function was overwriting inputValue with stale state when called from selectOption(), causing displayed value to lag one selection behind. Additionally, filterValue was not being cleared when closing without selecting, causing the filter to persist and hide options on subsequent opens. Modified closeMenu() to accept shouldRestoreInput parameter to distinguish between: - Selection flow: Skip restoration (value already set correctly) - Cancellation flow: Restore to previous selected value and clear filter Fixes patternfly#12146
Contributor
|
Preview: https://pf-react-pr-12147.surge.sh A11y report: https://pf-react-pr-12147-a11y.surge.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The closeMenu() function was overwriting inputValue with stale state when called from selectOption(), causing displayed value to lag one selection behind.
Additionally, filterValue was not being cleared when closing without selecting, causing the filter to persist and hide options on subsequent opens.
Modified closeMenu() to accept shouldRestoreInput parameter to distinguish between:
Fixes #12146
What: Closes #
Additional issues: