Skip to content

fix(react-templates): fix TypeaheadSelect state synchronization issue #12147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(react-templates): fix TypeaheadSelect state synchronization issue #12147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions packages/react-templates/src/components/Select/TypeaheadSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,13 +195,20 @@ export const TypeaheadSelectBase: FunctionComponent<TypeaheadSelectProps> = ({
}
};

const closeMenu = () => {
const closeMenu = (shouldRestoreInput = true) => {
onToggle && onToggle(false);
setIsOpen(false);
resetActiveAndFocusedItem();
const option = initialOptions.find((o) => o.value === selected);
if (option) {
setInputValue(String(option.content));

// Only restore input value when user cancels (doesn't select)
// Don't restore when explicitly selecting an option (handled by selectOption)
if (shouldRestoreInput) {
const option = initialOptions.find((o) => o.value === selected);
if (option) {
setInputValue(String(option.content));
}
// Clear filter when closing without selecting to show all options on next open
setFilterValue('');
}
};

Expand All @@ -223,7 +230,7 @@ export const TypeaheadSelectBase: FunctionComponent<TypeaheadSelectProps> = ({
setFilterValue('');
setSelected(String(option.value));

closeMenu();
closeMenu(false); // Don't restore - we just set the correct value above
};

const _onSelect = (_event: ReactMouseEvent<Element, MouseEvent> | undefined, value: string | number | undefined) => {
Expand Down