Skip to content

fix(network): prevent metric leak in outgoing message queue on session teardown #18847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

fix(network): prevent metric leak in outgoing message queue on session teardown #18847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions crates/net/network/src/session/active.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,6 +924,16 @@ impl<N: NetworkPrimitives> QueuedOutgoingMessages<N> {
}
}

impl<N: NetworkPrimitives> Drop for QueuedOutgoingMessages<N> {
fn drop(&mut self) {
// Ensure gauge is decremented for any remaining items to avoid metric leak on teardown.
let remaining = self.messages.len();
if remaining > 0 {
self.count.decrement(remaining as f64);
}
}
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down
Loading