fix(network): prevent metric leak in outgoing message queue on session teardown #18847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a metric leak in
QueuedOutgoingMessages
where theGauge
counter could become permanently inflated when sessions terminate with messages still queued.Problem
The
Gauge
metric was only decremented on explicitpop_front()
calls, but never when the queue was destroyed. If a session terminated with pending messages in the queue, the metric would remain artificially high indefinitely, causing:Solution
Added a
Drop
implementation forQueuedOutgoingMessages
that decrements the gauge by the number of remaining messages when the struct is destroyed.