Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 0 additions & 56 deletions GemCity.rb

This file was deleted.

2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
source 'https://rubygems.org'

gem 'rubocop', require: false
gem 'rspec'
gem 'rspec'
48 changes: 48 additions & 0 deletions gem_city.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
# This class represents the town of GemCity
# This is a town riddled with crime but we can find out how happy the town is
class GemCity
attr_reader :population

def initialize
@people = { thieves: 5, officers: 1 }
@population = 50
end

def thieves(thieves_number = @people[:thieves])
@people[:thieves] = thieves_number
end

def officers
@people[:officers]
end

def officers=(officers)
@people[:officers] = officers
end

def happiness_of_town
# happiness is random... people don't know what they want!
happiness_vals = []
happiness = 0
(1..@population).each do
happiness_vals.push(rand((100 - successful_crime_rate)..100))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move out the logic in this loop to another function, cause it's a little hairy in here with the rands and the constant values

end
happiness_vals.each do |value|
Copy link
Contributor

@paradime paradime May 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to use something called a Array#reduce here. Also, you can use the one line block syntax here to save some space. array.each{ |value| #do_something }

happiness += value
end
happiness / 100
end

def successful_crime_rate
thieves = @people[:thieves]
officers = @people[:officers]
if thieves <= 0
0
elsif officers > thieves
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about combining two assertions in the same line here using the || operator.

0
else
odds = 1 / (-officers.to_f / thieves.to_f)
odds * 100
end
end
end