Completed #19
Open
Completed #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems good. |
| happiness_vals = [] | ||
| happiness = 0 | ||
| (1..@population).each do | ||
| happiness_vals.push(rand((100 - successful_crime_rate)..100)) |
There was a problem hiding this comment.
Maybe move out the logic in this loop to another function, cause it's a little hairy in here with the rands and the constant values
|
Looking good so far, you should try out the extra credit, Using TDD! |
|
My impression from the instructions was that I was supposed to get the code to pass the Rubocop tests, which it does. These are great notes and good to keep in mind for the future though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maxdignan @kmodlich