Skip to content

feat: [EUDIW-209] Add Remote presentation for Potential #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jan 24, 2025

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Jan 15, 2025

List of Changes

  • Move verifyTokenSignature to dedicated method which is executed after getting Request Object
  • Added the ability to fetch a presentation definition from multiple sources, including directly from the request object, from a URI in the Relying Party (RP) configuration, or based on the scope.
  • Extended evaluateInputDescriptionForSdJwt4VC() to enforce required/optional fields and validate JSON schema filters on disclosed claims.
  • Implemented limit_disclosure handling to restrict data revealed to only those fields explicitly required.
  • Replaced the old sendAuthorizationResponse flow with a new module that supports both direct post and encrypted direct post (JWT) response modes.
  • Updated documentation, code structure, and tests to reflect these new capabilities and ensure better maintainability.

Motivation and Context

These changes are specifically targeted for the Potential use case and some logic are been made in order to support also the Italian specification.

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added the feat label Jan 15, 2025
@manuraf manuraf changed the title feat: [EUDIW-209] Add Remote presentation for Potential specs feat: [EUDIW-209] Add Remote presentation for Potential Jan 15, 2025
@manuraf manuraf marked this pull request as ready for review January 24, 2025 09:25
@manuraf manuraf requested a review from a team as a code owner January 24, 2025 09:25
@manuraf manuraf requested review from mastro993 and hevelius January 24, 2025 09:25
Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuraf manuraf added this pull request to the merge queue Jan 24, 2025
Merged via the queue into eudiw-master with commit efb1e93 Jan 24, 2025
6 checks passed
@manuraf manuraf deleted the feature/EUDIW-209-presentation-definition branch January 24, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants