feat: [EUDIW-209] Add Remote presentation for Potential #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuraf
changed the title
…ition # Conflicts: # src/credential/presentation/__tests__/04-retrieve-jwks.test.ts
Comment on lines
16
to
29
| let pubKey; | ||
|
|
||
| // verify token signature to ensure the request object is authentic | ||
| if (jwkKeys) { | ||
| pubKey = jwkKeys.find( | ||
| ({ kid }) => kid === requestObjectJwt.protectedHeader.kid | ||
| ); | ||
| } | ||
|
|
||
| if (!pubKey) { | ||
| throw new UnverifiedEntityError("Request Object signature verification!"); | ||
| } | ||
| await verify(requestObjectEncodedJwt, pubKey); | ||
|
|
There was a problem hiding this comment.
Usually we avoid the usage of let as much as possibile to prefer an immutable data approach. This could be refactored as:
const pubKey = jwkKeys?.find(
({ kid }) => kid === requestObjectJwt.protectedHeader.kid
);
if (!pubKey) {
throw new UnverifiedEntityError("Request Object signature verification!");
}
What do you think?
Comment on lines
157
to
158
| let requiredClaimNames: string[] = []; | ||
| let optionalClaimNames: string[] = []; |
Comment on lines
+169
to
+172
| let [matchedPath, matchedValue] = findMatchedClaim( | ||
| field.path, | ||
| disclosuresAsPayload | ||
| ); |
There was a problem hiding this comment.
here is more complicated using const because matchedPath really change...maybe enforce to use const could cause the code to become less readable
Comment on lines
225
to
239
| let requestBody: string; | ||
| if (requestObject.response_mode === "direct_post.jwt") { | ||
| requestBody = await buildDirectPostJwtBody( | ||
| jwkKeys, | ||
| requestObject, | ||
| vp_token, | ||
| presentation_submission | ||
| ); | ||
| } else { | ||
| requestBody = await buildDirectPostBody( | ||
| requestObject, | ||
| vp_token, | ||
| presentation_submission | ||
| ); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
verifyTokenSignatureto dedicated method which is executed after getting Request Objectscope.evaluateInputDescriptionForSdJwt4VC()to enforce required/optional fields and validate JSON schema filters on disclosed claims.limit_disclosurehandling to restrict data revealed to only those fields explicitly required.sendAuthorizationResponseflow with a new module that supports both direct post and encrypted direct post (JWT) response modes.Motivation and Context
These changes are specifically targeted for the Potential use case and some logic are been made in order to support also the Italian specification.
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: