Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [WLEO-218] Add Remote Presentation Cross-Device to Example App #178

Merged

Conversation

manuraf
Copy link

@manuraf manuraf commented Jan 24, 2025

List of Changes

Permission Management:
Added to AndroidManifest.xml and included NSCameraUsageDescription in Info.plist with a descriptive message.

Camera Integration:
Installed react-native-vision-camera and updated SWIFT_VERSION from 5.0 to 5.2 in the Xcode project configuration.

Remote Presentation Feature:

  • Added PresentationScreen and QrScannerScreen to MainStackNavigator.tsx.
  • Created PresentationScreen.tsx and QrScannerScreen.tsx for handling presentations and QR scanning.
  • Implemented remoteCrossDevicePresentationThunk in presentation.ts to manage the presentation flow.

Motivation and Context

This pull request enhances the Example App by incorporating the Remote Presentation Cross-Device functionality implemented in PR #174. The key motivations include allow users to scan QR codes necessary for initiating and managing remote presentations by adding required camera permissions and integrating a camera library.

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf marked this pull request as ready for review January 24, 2025 14:48
@manuraf manuraf requested a review from a team as a code owner January 24, 2025 14:48
@manuraf manuraf requested review from ale-mazz and hevelius January 24, 2025 14:48
Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LazyAfternoons LazyAfternoons added this pull request to the merge queue Jan 28, 2025
Merged via the queue into eudiw-master with commit 631c9cc Jan 28, 2025
6 checks passed
@LazyAfternoons LazyAfternoons deleted the feature/WLEO-218-add-pid-presentation-example branch January 28, 2025 09:53
gispada pushed a commit that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants