-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [IOBP-1095] Replace legacy headers for IDPay screens #6583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace TopScreenComponent with useHeaderSecondLevel
replace BaseScreenComponent with useHeaderSecondLevel
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOBP-1095 |
Hantex9
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
LGTM! 🚀
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
#6584) ## Short description This pull request align legacy IDPay switch/radio components with design standards > [!WARNING] > This PR depends on #6583 ## List of changes proposed in this pull request - Replace `ListItemComponent` with `ListItemSwitch` for switch rendering - Replace `ListItemComponent` with `RadioGroup` for radio rendering ## How to test Ensure that all legacy IDPay switch/radio are aligned with the established design requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pull request focuses on refactoring multiple screens in the
IDPay
feature to use theuseHeaderSecondLevel
hook instead of theTopScreenComponent
andBaseScreenComponent
components. Additionally, it includes a minor update to a test fileList of changes proposed in this pull request
TopScreenComponent
withuseHeaderSecondLevel
hookBaseScreenComponent
withuseHeaderSecondLevel
hookHow to test
Ensure that all IDPay headers are fully aligned with the established design requirements