Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [IOBP-1095] Replace legacy headers for IDPay screens #6583

Merged
merged 9 commits into from
Jan 14, 2025

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request focuses on refactoring multiple screens in the IDPay feature to use the useHeaderSecondLevel hook instead of the TopScreenComponent and BaseScreenComponent components. Additionally, it includes a minor update to a test file

List of changes proposed in this pull request

  • Replaced TopScreenComponent with useHeaderSecondLevel hook
  • Replaced BaseScreenComponent with useHeaderSecondLevel hook

How to test

Ensure that all IDPay headers are fully aligned with the established design requirements

replace TopScreenComponent with useHeaderSecondLevel
replace BaseScreenComponent with useHeaderSecondLevel
@LeleDallas LeleDallas added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Jan 3, 2025
@LeleDallas LeleDallas self-assigned this Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOBP-1095

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 2.77778% with 35 lines in your changes missing coverage. Please review.

Project coverage is 49.33%. Comparing base (ea2663f) to head (c7ec4e3).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../profile/playgrounds/IdPayOnboardingPlayground.tsx 0.00% 6 Missing ⚠️
...uration/screens/IdPayDiscountInstrumentsScreen.tsx 0.00% 5 Missing ⚠️
...figuration/screens/InstrumentsEnrollmentScreen.tsx 0.00% 5 Missing ⚠️
...pay/configuration/screens/IbanEnrollmentScreen.tsx 0.00% 4 Missing ⚠️
...boarding/screens/MultiValuePrerequisitesScreen.tsx 0.00% 4 Missing ⚠️
...atures/idpay/code/screens/IdPayCodeRenewScreen.tsx 0.00% 2 Missing ⚠️
...creens/profile/playgrounds/IdPayCodePlayground.tsx 0.00% 2 Missing ⚠️
...uration/screens/IbanConfigurationLandingScreen.tsx 0.00% 1 Missing ⚠️
...pay/configuration/screens/IbanOnboardingScreen.tsx 0.00% 1 Missing ⚠️
...ion/screens/InitiativeConfigurationIntroScreen.tsx 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6583      +/-   ##
==========================================
- Coverage   49.36%   49.33%   -0.03%     
==========================================
  Files        1565     1565              
  Lines       32230    32239       +9     
  Branches     7290     7288       -2     
==========================================
- Hits        15910    15906       -4     
- Misses      16282    16295      +13     
  Partials       38       38              
Files with missing lines Coverage Δ
...ures/idpay/code/screens/IdPayCodeDisplayScreen.tsx 96.15% <100.00%> (+0.15%) ⬆️
...uration/screens/IbanConfigurationLandingScreen.tsx 20.00% <0.00%> (-2.23%) ⬇️
...pay/configuration/screens/IbanOnboardingScreen.tsx 6.66% <0.00%> (ø)
...ion/screens/InitiativeConfigurationIntroScreen.tsx 15.00% <0.00%> (+0.71%) ⬆️
...ures/idpay/onboarding/screens/CompletionScreen.tsx 20.00% <0.00%> (-2.23%) ⬇️
...ayment/screens/IDPayPaymentAuthorizationScreen.tsx 12.50% <0.00%> (-0.41%) ⬇️
...ay/payment/screens/IDPayPaymentCodeInputScreen.tsx 11.76% <0.00%> (-0.74%) ⬇️
...ption/screens/UnsubscriptionConfirmationScreen.tsx 6.25% <0.00%> (ø)
...atures/idpay/code/screens/IdPayCodeRenewScreen.tsx 13.33% <0.00%> (-0.96%) ⬇️
...creens/profile/playgrounds/IdPayCodePlayground.tsx 10.00% <0.00%> (-1.12%) ⬇️
... and 5 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5333333...c7ec4e3. Read the comment docs.

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

LGTM! 🚀

@LeleDallas LeleDallas added this pull request to the merge queue Jan 14, 2025
Merged via the queue into master with commit b03d94e Jan 14, 2025
21 checks passed
@LeleDallas LeleDallas deleted the IOBP-1095-new-header-for-idpay-screens branch January 14, 2025 23:35
github-merge-queue bot pushed a commit that referenced this pull request Jan 15, 2025
#6584)

## Short description
This pull request align legacy IDPay switch/radio components with design
standards

> [!WARNING]
> This PR depends on #6583 

## List of changes proposed in this pull request
- Replace `ListItemComponent` with `ListItemSwitch` for switch rendering
- Replace `ListItemComponent` with `RadioGroup` for radio rendering

## How to test
Ensure that all legacy IDPay switch/radio are aligned with the
established design requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants