refactor: [IOBP-1094] Standardize legacy switch/radio for IDPay screen #6584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace TopScreenComponent with useHeaderSecondLevel
replace BaseScreenComponent with useHeaderSecondLevel
LeleDallas
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOBP-1094 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6584 +/- ##
=======================================
Coverage 49.33% 49.33%
=======================================
Files 1565 1565
Lines 32275 32270 -5
Branches 7290 7337 +47
=======================================
- Hits 15923 15921 -2
+ Misses 16313 16311 -2
+ Partials 39 38 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
… IDPay (#6586) ## Short description This PR is replacing legacy components for IDPay screens to align them with design standards > [!WARNING] > This PR depends on #6584 ## List of changes proposed in this pull request - Import `FooterActions` from design system - Replace `RNavScreenWithLargeHeader` with `IOScrollViewWithLargeHeader` - Replace `GradientScrollView` with `IOScrollViewWithLargeHeader` (thanks @dmnplb) - Replace `jest` deprecated functions (`toBeCalledWith`, `toBeCalledTimes` and `toBeCalled`) - Replace deprecated `Layout` of `react-native-reanimated` with `LinearTransition` - Remove `back` button in onboarding screens with `IOScrollViewWithLargeHeader` - Replace all scrollview with `IOScrollViewWithLargeHeader` ## How to test Ensure that all legacy components are replaced and properly aligned with standards ## Preview | Old | New | |--------|--------| | <video src="https://github.com/user-attachments/assets/42a300ba-c1ec-4dfd-b647-062b46c07773"> | <video src="https://github.com/user-attachments/assets/b8d0a8b7-7b6e-4e14-94d1-672c2601cd16"> | | <video src="https://github.com/user-attachments/assets/93951690-9b9a-4978-aa42-344e47f33cc9"> | <video src="https://github.com/user-attachments/assets/a773d730-19b1-44ac-b3ac-7f1a01a1905f"> | | <video src="https://github.com/user-attachments/assets/ecb84428-0cbe-48f4-beb3-82988a7df429"> | <video src="https://github.com/user-attachments/assets/881bf976-4bef-495f-918c-86c01c4ede1c"> | | <video src="https://github.com/user-attachments/assets/7fad0a6d-1cb1-4073-bd26-e63753ed8490"> | <video src="https://github.com/user-attachments/assets/ea01e06b-8c2b-4fec-8a78-21f654cab03f"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pull request align legacy IDPay switch/radio components with design standards
Warning
This PR depends on #6583
List of changes proposed in this pull request
ListItemComponentwithListItemSwitchfor switch renderingListItemComponentwithRadioGroupfor radio renderingHow to test
Ensure that all legacy IDPay switch/radio are aligned with the established design requirements