Skip to content

Clarify sending ActionProfile members with duplicate actions. #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarify sending ActionProfile members with duplicate actions. #559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/v1/P4Runtime-Spec.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3990,7 +3990,8 @@ inserted. Therefore, 3 distinct `WriteRequest` batches are required.

It is possible to include several `ActionProfileAction` messages with the same
exact `action` specification in one `ActionProfileActionSet` message. However,
Copy link
Member

@smolkaj smolkaj Aug 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From P4 API WG: Let's discuss the two cases (sum of members and sum of weights separtely) to make this clearer, and ideally include an example for each.

Suggested phrasing:

  • For sum_of_members, this can be useful <reason>
    <example>
  • For sum_of_weights, this is allowed but discouraged, because such ... can always be collapsed into a single message, like so:
    <example>

the P4Runtime client is encouraged not to do so, as the same can be achieved by
when using the `sum_of_weights` group size calculation, the P4Runtime client is
encouraged not to do so, as the same can be achieved by
using the `weight` field. Note that to preserve read-write symmetry, the server
must not coalesce multiple `ActionProfileAction` messages with the same `action`
specification into one. Additionally, each `action` specification would count as
Expand Down
Loading