Clarify sending ActionProfile members with duplicate actions. #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, clarify that P4Runtime clients are only discouraged from sending ActionProfile members with duplicate actions when using the `sum_of_weights` group size calculation, since the same may literally not be achievable using the `weight` field otherwise. Signed-off-by: Jonathan DiLorenzo <[email protected]>
Could you provide a concrete example? I may be slow to understand, but I'm not seeing it. |
|
Did you by any chance |
smolkaj
requested changes
Aug 8, 2025
| inserted. Therefore, 3 distinct `WriteRequest` batches are required. | ||
|
|
||
| It is possible to include several `ActionProfileAction` messages with the same | ||
| exact `action` specification in one `ActionProfileActionSet` message. However, |
There was a problem hiding this comment.
From P4 API WG: Let's discuss the two cases (sum of members and sum of weights separtely) to make this clearer, and ideally include an example for each.
Suggested phrasing:
- For
sum_of_members, this can be useful <reason>
<example> - For
sum_of_weights, this is allowed but discouraged, because such ... can always be collapsed into a single message, like so:
<example>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, clarify that P4Runtime clients are only discouraged from sending ActionProfile members with duplicate actions when using the
sum_of_weightsgroup size calculation, since the same may literally not be achievable using theweightfield otherwise.