-
Notifications
You must be signed in to change notification settings - Fork 82
Add testing helper for DELETE requests #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This introduces test_util.object_delete(), to go along with the existing test_util helpers.
Hmm, those tests seem to be failing for me on main. Not sure what's going on there |
What's the error message you're seeing? I just did (Edit: I see it - in actions, though not locally. More detail below) |
Ahhhh taking a closer look here - and at https://github.com/oxidecomputer/dropshot/actions - I think the reason tests (unrelated to your PR) tests are failing is because:
Eyeballing it, it actually kinda looks like the only line that changed was actually part of the compiler message giving path hints: Expected: vs Actual: I'll follow-up with a separate issue. |
Filed #138 |
Okay, should be ready for another review. Tests all pass locally after merging #139 in |
Hmm, the windows build failed
This seems unrelated to my change; I can open a ticket for this |
It passed on a re-run. I opened #141 to track |
This introduces test_util.object_delete(), to go along with the existing test_util helpers. It's helpful for testing CRUD APIs.