Skip to content

Actions can be broken by changed compiler output #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smklein opened this issue Oct 13, 2021 · 2 comments · Fixed by #139 or #140
Closed

Actions can be broken by changed compiler output #138

smklein opened this issue Oct 13, 2021 · 2 comments · Fixed by #139 or #140
Assignees

Comments

@smklein
Copy link
Contributor

smklein commented Oct 13, 2021

https://github.com/oxidecomputer/dropshot/pull/136/checks?check_run_id=3877374795 has an example

Paraphrasing from my comment elsewhere:

  • We have some tests that check for "compiler failures" looking like we want
  • I suspect the compiler changed, and the compiler output changed
  • This change - though probably innocent - caused "expected != actual", and the test failed.

The only line that changed was actually part of the compiler message giving path hints:

Expected: ::: $WORKSPACE/dropshot/src/api_description.rs

vs

Actual: ::: src/api_description.rs:54:33

This is repro-d on a no-op change: #137

@smklein
Copy link
Contributor Author

smklein commented Oct 13, 2021

After noticing that #139 did not fix this, I tried #140.

I still think #139 is probably worthwhile doing, but this is another source of variability: dependencies. The issue wasn't a toolchain revision, but some dependency causing different output. I have not dug into the dependencies to figure out what caused this particular change.

smklein added a commit that referenced this issue Oct 13, 2021
This fixes the short-term problem caused by #138, but not the root cause.
@smklein
Copy link
Contributor Author

smklein commented Oct 13, 2021

Re-opening, as the potential for this issue still exists even with #140 merged.

#139 provides a long-term solution.

@smklein smklein reopened this Oct 13, 2021
@smklein smklein changed the title Actions broken by changed compiler output Actions can be broken by changed compiler output Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant