refactor(ast): change capitalization of CommentKind variants
#16640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
This was referenced Dec 9, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
graphite-app
bot
changed the base branch from
12-04-refactor_formatter_rename_commentkind_block_to_commentkind_singlelineblock
to
graphite-base/16640
CodSpeed Performance ReportMerging #16640 will not alter performanceComparing Summary
Footnotes
|
graphite-app
bot
force-pushed
the
12-09-refactor_ast_change_capitalization_of_commentkind_variants
branch
from
d1852d1 to
2df8c86
Compare
graphite-app
bot
force-pushed
the
graphite-base/16640
branch
from
9f08971 to
320c09f
Compare
graphite-app
bot
force-pushed
the
12-09-refactor_ast_change_capitalization_of_commentkind_variants
branch
from
2df8c86 to
2bb359a
Compare
Dunqing
approved these changes
Dec 9, 2025
Member
Merge activity
|
Pure refactor. "multiline" is OK, but "singleline" is ungrammatical - it should be hyphenated ("single-line"). So rename the `CommentKind` variant to `SingleLineBlock`. Also rename `MultilineBlock` -> `MultiLineBlock` for consistency.
Obviously, this is not important. But as changing the variants of `CommentKind` is already a breaking change, it seems like the right moment to nitpick - and avoid getting stuck with it, or having to make another breaking change later.
graphite-app
bot
force-pushed
the
12-09-refactor_ast_change_capitalization_of_commentkind_variants
branch
from
2bb359a to
7da5c22
Compare
graphite-app
bot
deleted the
12-09-refactor_ast_change_capitalization_of_commentkind_variants
branch
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
Pure refactor. "multiline" is OK, but "singleline" is ungrammatical - it should be hyphenated ("single-line"). So rename the `CommentKind` variant to `SingleLineBlock`. Also rename `MultilineBlock` -> `MultiLineBlock` for consistency.
Obviously, this is not important. But as changing the variants of `CommentKind` is already a breaking change, it seems like the right moment to nitpick - and avoid getting stuck with it, or having to make another breaking change later.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…roject#16640) Pure refactor. "multiline" is OK, but "singleline" is ungrammatical - it should be hyphenated ("single-line"). So rename the `CommentKind` variant to `SingleLineBlock`. Also rename `MultilineBlock` -> `MultiLineBlock` for consistency. Obviously, this is not important. But as changing the variants of `CommentKind` is already a breaking change, it seems like the right moment to nitpick - and avoid getting stuck with it, or having to make another breaking change later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. "multiline" is OK, but "singleline" is ungrammatical - it should be hyphenated ("single-line"). So rename the
CommentKindvariant toSingleLineBlock. Also renameMultilineBlock->MultiLineBlockfor consistency.Obviously, this is not important. But as changing the variants of
CommentKindis already a breaking change, it seems like the right moment to nitpick - and avoid getting stuck with it, or having to make another breaking change later.