Skip to content

feat(ast, parser, linter, codegen, formatter)!: rename CommentKind::Block to CommentKind::SinglelineBlock #16501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Dec 9, 2025
Merged

feat(ast, parser, linter, codegen, formatter)!: rename CommentKind::Block to CommentKind::SinglelineBlock #16501

graphite-app merged 1 commit into from
Dec 9, 2025
+31 −24

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 4, 2025 •
edited
Loading

#16479 introduced a new kind called CommentKind::MultilineBlock, which means a block comment that has at least one line break. Therefore, CommentKind::Block means it is a single-line block.

In this PR, rename CommentKind::Block to CommentKind::SinglelineBlock to make the kind name more descriptive.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-ast Area - AST A-codegen Area - Code Generation A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 4, 2025
@Dunqing Dunqing mentioned this pull request Dec 4, 2025
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Dec 4, 2025 •
edited by overlookmotel
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Dec 4, 2025
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 4, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #16501 will not alter performance

Comparing 12-04-refactor_formatter_rename_commentkind_block_to_commentkind_singlelineblock (8173ec5) with 12-04-refactor_formatter_simplify_checking_multiline_block_comment (00e08ca)

Summary

✅ 42 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Dunqing Dunqing changed the title refactor(formatter): rename CommentKind::Block to CommentKind::SinglelineBlock refactor(ast, parser, linter, codegen, formatter): rename CommentKind::Block to CommentKind::SinglelineBlock Dec 4, 2025
@Dunqing Dunqing requested a review from overlookmotel December 4, 2025 15:03
@Dunqing Dunqing marked this pull request as ready for review December 4, 2025 15:03
@Dunqing Dunqing requested a review from camc314 as a code owner December 4, 2025 15:04
@Dunqing Dunqing force-pushed the 12-04-refactor_formatter_rename_commentkind_block_to_commentkind_singlelineblock branch from e175945 to 8173ec5 Compare December 7, 2025 15:25
@Dunqing Dunqing force-pushed the 12-04-refactor_formatter_simplify_checking_multiline_block_comment branch from 77c20fe to 00e08ca Compare December 7, 2025 15:25
@graphite-app graphite-app bot changed the base branch from 12-04-refactor_formatter_simplify_checking_multiline_block_comment to graphite-base/16501 December 9, 2025 02:02
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
@overlookmotel Graphite App
Copy link
Member

overlookmotel commented Dec 9, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Dec 9, 9:14 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 9, 9:15 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Dec 9, 9:15 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Dec 9, 9:15 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 9, 9:45 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Dec 9, 9:50 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Dec 9, 9:56 AM UTC: Merged by the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 12-04-refactor_formatter_rename_commentkind_block_to_commentkind_singlelineblock branch from 8173ec5 to 9f08971 Compare December 9, 2025 09:44
@overlookmotel overlookmotel changed the base branch from graphite-base/16501 to main December 9, 2025 09:44
@overlookmotel
Copy link
Member

overlookmotel commented Dec 9, 2025

Graphite has gone screwy. I've rebased on latest main to fix it. Hopefully it should merge now.

@overlookmotel overlookmotel changed the title refactor(ast, parser, linter, codegen, formatter): rename CommentKind::Block to CommentKind::SinglelineBlock feat!(ast, parser, linter, codegen, formatter): rename CommentKind::Block to CommentKind::SinglelineBlock Dec 9, 2025
@overlookmotel
Copy link
Member

overlookmotel commented Dec 9, 2025 •
edited
Loading

Also I've marked this as a breaking change, as it is a change which may affect downstream crate consumers. Really it was #16479 which was the main breaking change, but it's already merged.

@overlookmotel overlookmotel mentioned this pull request Dec 9, 2025
Merged
@overlookmotel overlookmotel changed the title feat!(ast, parser, linter, codegen, formatter): rename CommentKind::Block to CommentKind::SinglelineBlock feat(ast, parser, linter, codegen, formatter)!: rename CommentKind::Block to CommentKind::SinglelineBlock Dec 9, 2025
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Dec 9, 2025
@Dunqing
feat(ast, parser, linter, codegen, formatter)!: rename `CommentKind::…
320c09f 
…Block` to `CommentKind::SinglelineBlock` (#16501)

#16479 introduced a new kind called `CommentKind::MultilineBlock`, which means a block comment that has at least one line break. Therefore, `CommentKind::Block` means it is a single-line block.

In this PR, rename `CommentKind::Block` to `CommentKind::SinglelineBlock` to make the kind name more descriptive.
@graphite-app graphite-app bot force-pushed the 12-04-refactor_formatter_rename_commentkind_block_to_commentkind_singlelineblock branch from 9f08971 to 320c09f Compare December 9, 2025 09:50
@graphite-app graphite-app bot merged commit 320c09f into main Dec 9, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-04-refactor_formatter_rename_commentkind_block_to_commentkind_singlelineblock branch December 9, 2025 09:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
Copilot AI pushed a commit that referenced this pull request Dec 10, 2025
@Dunqing
feat(ast, parser, linter, codegen, formatter)!: rename `CommentKind::…
b789cc8 
…Block` to `CommentKind::SinglelineBlock` (#16501)

#16479 introduced a new kind called `CommentKind::MultilineBlock`, which means a block comment that has at least one line break. Therefore, `CommentKind::Block` means it is a single-line block.

In this PR, rename `CommentKind::Block` to `CommentKind::SinglelineBlock` to make the kind name more descriptive.
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@Dunqing @taearls
feat(ast, parser, linter, codegen, formatter)!: rename `CommentKind::…
cb2749a 
…Block` to `CommentKind::SinglelineBlock` (oxc-project#16501)

oxc-project#16479 introduced a new kind called `CommentKind::MultilineBlock`, which means a block comment that has at least one line break. Therefore, `CommentKind::Block` means it is a single-line block.

In this PR, rename `CommentKind::Block` to `CommentKind::SinglelineBlock` to make the kind name more descriptive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-ast Area - AST A-codegen Area - Code Generation A-formatter Area - Formatter A-linter Area - Linter A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dunqing @overlookmotel