Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli/init): refactor init.test.ts #16297

Open
wants to merge 1 commit into
base: 01-09-feat_cli_init_new_repos_use_text-based_lockfile
Choose a base branch
from

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jan 9, 2025

What does this PR do?

Refactors init.test.ts to break expectations into separate tests. Each tested command is still run only once.

How did you verify your code works?

Only tests are changed.

@robobun
Copy link

robobun commented Jan 9, 2025

Updated 10:08 PM PT - Jan 10th, 2025

@DonIsaac, your commit d204639 has passed in #9438! 🎉


🧪   try this PR locally:

bunx bun-pr 16297

Copy link
Contributor Author

DonIsaac commented Jan 9, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@DonIsaac DonIsaac marked this pull request as ready for review January 9, 2025 22:35
@DonIsaac DonIsaac requested review from a team and zackradisic and removed request for a team January 9, 2025 22:35
@DonIsaac DonIsaac force-pushed the 01-09-feat_cli_init_new_repos_use_text-based_lockfile branch from adfcb9a to 63952ed Compare January 11, 2025 01:14
@DonIsaac DonIsaac force-pushed the 01-09-test_cli_init_refactor_init.test.ts branch from 1d9bc5c to 93c52fa Compare January 11, 2025 01:14
@DonIsaac DonIsaac force-pushed the 01-09-feat_cli_init_new_repos_use_text-based_lockfile branch from 63952ed to a81b130 Compare January 11, 2025 04:18
@DonIsaac DonIsaac force-pushed the 01-09-test_cli_init_refactor_init.test.ts branch from 93c52fa to 05dd987 Compare January 11, 2025 04:18
@DonIsaac DonIsaac force-pushed the 01-09-feat_cli_init_new_repos_use_text-based_lockfile branch from a81b130 to 254133c Compare January 11, 2025 05:00
@DonIsaac DonIsaac force-pushed the 01-09-test_cli_init_refactor_init.test.ts branch from 05dd987 to d204639 Compare January 11, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants