Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli/init): deduplicate asset creation logic #16294

Merged

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jan 9, 2025

What does this PR do?

Centralizes asset creation logic for bun init.

How did you verify your code works?

I wrote automated tests

@robobun
Copy link

robobun commented Jan 9, 2025

Updated 6:06 PM PT - Jan 10th, 2025

@DonIsaac, your commit e0f08ac has 1 failures in #9395:


🧪   try this PR locally:

bunx bun-pr 16294

Copy link
Contributor Author

DonIsaac commented Jan 9, 2025

@DonIsaac DonIsaac requested a review from dylan-conway January 9, 2025 22:11
@DonIsaac DonIsaac marked this pull request as ready for review January 9, 2025 22:11
@DonIsaac
Copy link
Contributor Author

DonIsaac commented Jan 9, 2025

Builds are failing because Graphite's default branch name causes folder names to be too long on windows. I'll make another PR fixing this.

@DonIsaac DonIsaac force-pushed the 01-09-refactor_cli_init_deduplicate_asset_creation_logic branch from d918825 to e0f08ac Compare January 11, 2025 01:14
@DonIsaac DonIsaac enabled auto-merge January 11, 2025 01:29
@DonIsaac DonIsaac added this pull request to the merge queue Jan 11, 2025
Merged via the queue into main with commit b364c86 Jan 11, 2025
70 checks passed
@DonIsaac DonIsaac deleted the 01-09-refactor_cli_init_deduplicate_asset_creation_logic branch January 11, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants