Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to match code and fix a few typos #716

Merged
merged 11 commits into from
Jan 10, 2025

Conversation

imnasnainaec
Copy link
Contributor

@imnasnainaec imnasnainaec commented Aug 9, 2024

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cookieconsent-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 2:41pm

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for cookieconsentv3-playground canceled.

Name Link
🔨 Latest commit 9f98698
🔍 Latest deploy log https://app.netlify.com/sites/cookieconsentv3-playground/deploys/66c74e0882949c000800fc1f

@imnasnainaec imnasnainaec changed the title Update getting-started.md expiresAfterDays to match code Update docs to match code Aug 9, 2024
@imnasnainaec imnasnainaec changed the title Update docs to match code Update docs to match code and fix a few typos Aug 9, 2024
Copy link

stale bot commented Sep 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2024
@imnasnainaec
Copy link
Contributor Author

Most of this pr is typo corrections, but there are two inaccuracies in the docs that this fixes:

  • The docs said the cookie default expiration is 365 days, but it's actually 182;
  • The contributor docs have an incorrect pnpm command.

@stale stale bot removed the stale label Sep 23, 2024
Copy link

stale bot commented Oct 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 28, 2024
@imnasnainaec
Copy link
Contributor Author

@orestbida Are there any parts of this pr you'd like me to roll back?

@stale stale bot removed the stale label Oct 29, 2024
Copy link

stale bot commented Dec 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 3, 2024
@orestbida orestbida removed the stale label Dec 3, 2024
Copy link

stale bot commented Jan 4, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 4, 2025
@imnasnainaec
Copy link
Contributor Author

Happy new year!

@stale stale bot removed the stale label Jan 6, 2025
@orestbida orestbida merged commit bf6db3a into orestbida:master Jan 10, 2025
7 checks passed
@orestbida
Copy link
Owner

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants