Skip to content

Commit bf6db3a

Browse files
authored
Merge pull request #716 from imnasnainaec/patch-1
Update docs to match code and fix a few typos
2 parents b0e85f8 + 9f98698 commit bf6db3a

File tree

11 files changed

+18
-18
lines changed

11 files changed

+18
-18
lines changed

CONTRIBUTING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ If you encountered a problem, [search if an issue already exists](https://github
2323
npm i -g pnpm
2424
```
2525

26-
3. Follow the [Getting started with Github Desktop](https://docs.github.com/en/desktop/installing-and-configuring-github-desktop/overview/getting-started-with-github-desktop) guide.
26+
3. Follow the [Getting started with GitHub Desktop](https://docs.github.com/en/desktop/installing-and-configuring-github-desktop/overview/getting-started-with-github-desktop) guide.
2727

2828
1. #### Make changes locally
2929

@@ -43,7 +43,7 @@ If you encountered a problem, [search if an issue already exists](https://github
4343
pnpm dev
4444
```
4545

46-
Note: If you're making changes to the documentation, use `pnpm dev:docs`.
46+
Note: If you're making changes to the documentation, use `pnpm docs:dev`.
4747
4848
5. Once you've finished, generate the bundled version via:
4949

docs/additional/faq.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Frequently Asked Questions
2-
Couldn't find the answer in the documentation? Feel free to open a [discussion](https://github.com/orestbida/cookieconsent/discussions) on github.
2+
Couldn't find the answer in the documentation? Feel free to open a [discussion](https://github.com/orestbida/cookieconsent/discussions) on GitHub.
33

44
[[toc]]
55

docs/advanced/manage-scripts.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Example usage:
2222

2323
## How to block/manage a script tag
2424

25-
You can manage any script tag. by adding the following 2 attributes (both required):
25+
You can manage any script tag by adding the following 2 attributes (both required):
2626

2727
- `type="text/plain"`
2828
- `data-category="your-category-name"`
@@ -49,7 +49,7 @@ You can also run **scripts when a category is disabled** (if it was previously e
4949
<script
5050
type="text/plain"
5151
data-category="!analytics">
52-
// Executed when the "analytics category is disabled
52+
// Executed when the "analytics" category is disabled
5353
</script>
5454
```
5555

docs/components/icons.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/essential/getting-started.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ This section will help you install CookieConsent in your app/website.
77
You can download/import the plugin using one of the following methods:
88
<br>
99

10-
1. Install via [NPM](https://www.npmjs.com/package/vanilla-cookieconsent).
10+
1. Install via [NPM](https://www.npmjs.com/package/vanilla-cookieconsent) or [Yarn](https://yarnpkg.com/package?name=vanilla-cookieconsent).
1111

1212
::: code-group
1313

@@ -39,7 +39,7 @@ You can download/import the plugin using one of the following methods:
3939
https://cdn.jsdelivr.net/gh/orestbida/[email protected]/dist/cookieconsent.umd.js
4040
```
4141

42-
3. Download the [latest release](https://github.com/orestbida/cookieconsent/releases?q=cookieconsent+v3) from github and use the optimized files located in the `dist` folder.
42+
3. Download the [latest release](https://github.com/orestbida/cookieconsent/releases?q=cookieconsent+v3) from GitHub and use the optimized files located in the `dist` folder.
4343

4444

4545
## Usage
@@ -266,7 +266,7 @@ CookieConsent.run({
266266
// domain: location.hostname,
267267
// path: '/',
268268
// sameSite: "Lax",
269-
// expiresAfterDays: 365,
269+
// expiresAfterDays: 182,
270270
},
271271
272272
// https://cookieconsent.orestbida.com/reference/configuration-reference.html#guioptions
@@ -426,7 +426,7 @@ You should now see the consent modal pop up!
426426
You can also define [external translation files](/advanced/language-configuration.html#external-translations).
427427
:::
428428
429-
If you're having trouble setting up the plugin, you can check out a few [demo examples](https://github.com/orestbida/cookieconsent/tree/master/demo) on github.
429+
If you're having trouble setting up the plugin, you can check out a few [demo examples](https://github.com/orestbida/cookieconsent/tree/master/demo) on GitHub.
430430
431431
<br>
432432

docs/essential/introduction.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Both versions are very similar but there a few key differences:
3030
<CheckListItem title="Supports modern browsers only" type="i"/>
3131

3232
## More questions?
33-
Check the [FAQ](/additional/faq.html) section or open a [new discussion](https://github.com/orestbida/cookieconsent/discussions/new) on github.
33+
Check the [FAQ](/additional/faq.html) section or open a [new discussion](https://github.com/orestbida/cookieconsent/discussions/new) on GitHub.
3434

3535
<script setup>
3636
import CheckListItem from "../components/CheckListItem.vue"

docs/index.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ hero:
2121

2222
features:
2323
- title: Lightweight
24-
details: Small footprint with a minimal impact on your website's performance
24+
details: Small footprint with a minimal impact on your website's performance.
2525
- title: Versatile
2626
details: A wide range of options and API to handle many different types of configurations.
2727
- title: Accessible

docs/reference/configuration-reference.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,7 @@ Define the translation(s) content.
764764
```
765765
- **Details**:
766766

767-
You can define an `inline` translation object, or specify the path to an `external .json` translation file.
767+
You can define an `inline` translation object, or specify the path to an external `.json` translation file.
768768

769769
- **Examples**:
770770

@@ -833,7 +833,7 @@ Define the translation(s) content.
833833
- **Details**:
834834
- `closeIconLabel`: if specified, a big `X` button will be generated (visible only in the `box` layout). It acts the same as `acceptNecessaryBtn`.
835835
- `revisionMessage`: check out the dedicated [revision section](/advanced/revision-management.html#revision-message).
836-
- `footer`: a small area where you can place your links (impressum, privacy policy ...)
836+
- `footer`: a small area where you can place your links (impressum, privacy policy, ...)
837837

838838
<br>
839839

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
import '../../styles/header.scss';
33
import { docsUrl, stackblitzUrl, repoUrl } from "../../data/metadata";
4-
import { GithubIcon } from '../../data/icons';
4+
import { GitHubIcon } from '../../data/icons';
55
---
66
<header>
77
<h1 class="page-title">CookieConsent v3<span data-latest-release data-minor-release class="fade-in title__minor-version">.0.0</span></h1>
@@ -10,6 +10,6 @@ import { GithubIcon } from '../../data/icons';
1010
<div class="main-links">
1111
<a href={docsUrl} class="styled-link" target="_blank" rel="noopener noreferrer">📃 Documentation</a>
1212
<a href={stackblitzUrl} class="styled-link styled-link__2" target="_blank" rel="noopener noreferrer">Live demos</a>
13-
<a href={repoUrl} class="styled-link styled-link__2 github-icon" target="_blank" set:html={GithubIcon} aria-label="Github repository"></a>
13+
<a href={repoUrl} class="styled-link styled-link__2 github-icon" target="_blank" set:html={GitHubIcon} aria-label="GitHub repository"></a>
1414
</div>
1515
</header>

playground/src/components/sections/Help.astro

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import { docsUrl, repoUrl } from '../../data/metadata'
1717
</br>
1818
If you can't find what you're looking for, feel free to
1919
open an <a href={`${repoUrl}/issues`} target="_blank" rel="noopener noreferrer">issue</a>
20-
or a <a href={`${repoUrl}/discussions`} target="_blank" rel="noopener noreferrer">discussion</a> on github.
20+
or a <a href={`${repoUrl}/discussions`} target="_blank" rel="noopener noreferrer">discussion</a> on GitHub.
2121
</p>
2222
</div>
2323
</section>

playground/src/data/icons.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)