Skip to content

Avoid assert with convolutions with no strides or dilates. Issue #2829 #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pstarkcdpr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Avoid assert with convolutions with no strides or dilates. Issue #2829 #2880

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5941c84
Avoid assert with convolutions with no strides or dilates. Issue #2829
pstarkcdpr Dec 2, 2025
8c6ca73
Change the way null convolution dilates and strides are handled to de…
pstarkcdpr Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions stablehlo/conversions/linalg/transforms/StablehloToLinalgConvolution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,10 +248,12 @@ struct NormalConvolutionOpConversion final
resultType.getElementType(), dynSizes);
Value zeroTensor = fillTensorWithZeros(rewriter, loc, emptyTensor);
linalg::LinalgOp res;
Attribute strides;
if (auto s = op.getWindowStrides()) strides = rewriter.getI64TensorAttr(*s);
Attribute dilations;
if (auto d = op.getRhsDilation()) dilations = rewriter.getI64TensorAttr(*d);
auto s = op.getWindowStrides();
Attribute strides =
s ? rewriter.getI64TensorAttr(*s) : rewriter.getI64TensorAttr({1});
auto d = op.getRhsDilation();
Attribute dilations =
d ? rewriter.getI64TensorAttr(*d) : rewriter.getI64TensorAttr({1});

// Apply padding and input dilation.
llvm::SmallVector<int64_t> spatialDimMapping(rank - 2);
Expand Down