Skip to content

Conversation

@pstarkcdpr
Copy link

See issue #2829. A convolution without strides or dilates was causing spurious asserts.

@google-cla
Copy link

google-cla bot commented Dec 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@GleasonK
Copy link
Member

GleasonK commented Dec 2, 2025

Also can you sign the Google CLA when you get a chance, cant run the CI until thats completed

@pstarkcdpr
Copy link
Author

@GleasonK I'm checking if I'm allowed to agree to the CLA since I'm using a corporate account. I'll update when I know the answer. Alternately, this is such a simple change that if someone else wants to just do it and push it in, I'm fine with that and can cancel this PR if that gets done.

…al with only one of them being null.

Signed-off-by: Paul Stark <[email protected]>
@pstarkcdpr
Copy link
Author

@GleasonK I updated the PR based on your suggestion. It turns out that the original implementation had a real problem anyways, plus this is simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants