Move interop code to test/quic-openssl-docker #26546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its the only place we use this code, so put the code in that directory
Allow the building of the hq-interop client and server when we are building our interop container
Change the dockerfile to use enable-hqinterop and copy binaries from their new location
github-actions
bot
added
severity: fips change
t8m
added
approval: review pending
t8m
approved these changes
Jan 24, 2025
github-actions
bot
removed
severity: fips change
mattcaswell
approved these changes
Jan 24, 2025
mattcaswell
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
|
Merged to the feature branch. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 27, 2025
Its the only place we use this code, so put the code in that directory Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #26546)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 27, 2025
Allow the building of the hq-interop client and server when we are building our interop container Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #26546)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 27, 2025
Change the dockerfile to use enable-hqinterop and copy binaries from their new location Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #26546)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Feb 4, 2025
Its the only place we use this code, so put the code in that directory Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Feb 4, 2025
Allow the building of the hq-interop client and server when we are building our interop container Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Feb 4, 2025
Change the dockerfile to use enable-hqinterop and copy binaries from their new location Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
nhorman
added a commit
that referenced
this pull request
Feb 7, 2025
Its the only place we use this code, so put the code in that directory Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #26546)
nhorman
added a commit
that referenced
this pull request
Feb 7, 2025
Allow the building of the hq-interop client and server when we are building our interop container Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #26546)
nhorman
added a commit
that referenced
this pull request
Feb 7, 2025
Change the dockerfile to use enable-hqinterop and copy binaries from their new location Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #26546)
andrewkdinh
pushed a commit
to andrewkdinh/openssl
that referenced
this pull request
Feb 14, 2025
Its the only place we use this code, so put the code in that directory Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
andrewkdinh
pushed a commit
to andrewkdinh/openssl
that referenced
this pull request
Feb 14, 2025
Allow the building of the hq-interop client and server when we are building our interop container Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
andrewkdinh
pushed a commit
to andrewkdinh/openssl
that referenced
this pull request
Feb 14, 2025
Change the dockerfile to use enable-hqinterop and copy binaries from their new location Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Feb 14, 2025
Its the only place we use this code, so put the code in that directory Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Feb 14, 2025
Allow the building of the hq-interop client and server when we are building our interop container Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Feb 14, 2025
Change the dockerfile to use enable-hqinterop and copy binaries from their new location Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Feb 14, 2025
Its the only place we use this code, so put the code in that directory Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Feb 14, 2025
Allow the building of the hq-interop client and server when we are building our interop container Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Feb 14, 2025
Change the dockerfile to use enable-hqinterop and copy binaries from their new location Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
nhorman
added a commit
that referenced
this pull request
Feb 17, 2025
Its the only place we use this code, so put the code in that directory Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #26546)
nhorman
added a commit
that referenced
this pull request
Feb 17, 2025
Allow the building of the hq-interop client and server when we are building our interop container Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #26546)
nhorman
added a commit
that referenced
this pull request
Feb 17, 2025
Change the dockerfile to use enable-hqinterop and copy binaries from their new location Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #26546)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Feb 17, 2025
Its the only place we use this code, so put the code in that directory Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Feb 17, 2025
Allow the building of the hq-interop client and server when we are building our interop container Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Feb 17, 2025
Change the dockerfile to use enable-hqinterop and copy binaries from their new location Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
Sashan
pushed a commit
to vdukhovni/openssl
that referenced
this pull request
Feb 19, 2025
Its the only place we use this code, so put the code in that directory Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
Sashan
pushed a commit
to vdukhovni/openssl
that referenced
this pull request
Feb 19, 2025
Allow the building of the hq-interop client and server when we are building our interop container Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
Sashan
pushed a commit
to vdukhovni/openssl
that referenced
this pull request
Feb 19, 2025
Change the dockerfile to use enable-hqinterop and copy binaries from their new location Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
definability
pushed a commit
to definability/openssl
that referenced
this pull request
Feb 25, 2025
Its the only place we use this code, so put the code in that directory Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
definability
pushed a commit
to definability/openssl
that referenced
this pull request
Feb 25, 2025
Allow the building of the hq-interop client and server when we are building our interop container Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
definability
pushed a commit
to definability/openssl
that referenced
this pull request
Feb 25, 2025
Change the dockerfile to use enable-hqinterop and copy binaries from their new location Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
quarckster
pushed a commit
to quarckster/openssl-fork
that referenced
this pull request
Feb 27, 2025
Its the only place we use this code, so put the code in that directory Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
quarckster
pushed a commit
to quarckster/openssl-fork
that referenced
this pull request
Feb 27, 2025
Allow the building of the hq-interop client and server when we are building our interop container Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
quarckster
pushed a commit
to quarckster/openssl-fork
that referenced
this pull request
Feb 27, 2025
Change the dockerfile to use enable-hqinterop and copy binaries from their new location Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#26546)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the quic-hq-interop and quic-hq-interop-server code to test/quic-openssl-docker/hq-interop, as the interop container is the only thing that uses these applications
Note, prior to merge:
#26545
and
#26538
should be merged first