Force::isDisabled -->> Force::appliesForce #1407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty' into serialize-inputs
The challenge here was that the `isList` attribute of Inputs is not preserved upon deserialization. The temporary solution was to set the default `isList` value to true for Inputs, and then to re-set its value in finalizeFromProperties().
This commit reverts the model used in the testStaticOptimization passive force test to version 30000. Previously, the model was at version 30503, but we changed the Station connector's name from reference_frame to parent_frame after 30503 was first created. This commit also adds better exceptions to catch the error that happened. The new checks make sure that the properties for connectors/inputs are the ones the component is expecting.
…urce_filename_property' into serialize-inputs
…s' into serialize-inputs
Previously, Marker::updateFromXMLNode() had been invoking Object::updateFromXMLNode() instead of Super::updateFromXMLNode().
The connectee_name property now lives in the containing Component instead of in the Connector class. There is a lot left to do, but the tests mostly pass with this commit.
connector_<name>_connectees changed to: connector_<name>_connectee_name input_<name>_connectee_name input_<name>_connectee_names
Delete a bunch of code from the previous implementation of the Connector's connectee_name. Also updated some comments/doxygen.
Use Component& instead. This required giving out-of-line definitions for some methods. Still need to figure out what the best solution is with regard to const-correctness.
Also got rid of default constructors for Connectors.
…nectee_property_in_containing_component
…h_default_constructors
Ensure Path::_separator and Path::_isAbsolute are always initialized
Fixed assert_almost_equal where tol was not used
…_TwoFrameLinker_clang_warning
…t_input_wiring_exception
…ygen_for_declare_object_macros
Fix warnings from MSVC
Remove obsolete comment and messages
…macros Reveal macro-generated Object methods in doxygen.
…rning Get rid of TwoFrameLinker::scale() warning on clang.
Throw exception when requesting value of unconnected input.
Fix typos in test case messages
…github.com/opensim-org/opensim-core into issue_845_force_isDisabled_to_appliesForce_aseth # Conflicts: # OpenSim/Common/XMLDocument.cpp
|
Appears the diff is with master at the time this PR was opened. Find the current diff with master here. Sorry for the inconvenience. |
|
In my first review, I asked if the doxygen output for Force looked okay. Here is how it looks:
I think this looks a little confusing (it is not clear that the comment refers to the appliesForce property) and messy, and is not what @klshrinidhi intended. But this is a minor comment, and it can be ignored. |
|
The XMLDocument number should be 30509; 30508 is from my PR about connector/input serialization. |
…f string expressions for bool value. Update version number to 30509
|
@chrisdembia I updated the doxygen and description for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #845 only for
Force.Future PRs will address rest.