Skip to content

Add test case for model conversion #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aymanhab opened this issue Oct 9, 2014 · 12 comments
Open

Add test case for model conversion #206

aymanhab opened this issue Oct 9, 2014 · 12 comments

Comments

@aymanhab
Copy link
Member

aymanhab commented Oct 9, 2014

To make sure old models deserialize and display correctly, need a textual rep of Display and a suite of old models using old format.

@jenhicks jenhicks added this to the OpenSim 4.0 milestone Oct 9, 2014
@jenhicks
Copy link
Member

@aymanhab Is this still an open issue (per your OpenSim 4.0 presentation)?

@jenhicks
Copy link
Member

Additional comment from @aseth1
Most components are verified by virtue of older model files being used by other test cases. But in many test cases (esp. Joints, Constraints and Forces) models are built programmatically (without loading a model from file) and the serialization loop is tested only in the latest version.

In order to ensure that the content of older models is preserved they must be verified to contain the same content in the latest version of the model.

@aymanhab
Copy link
Member Author

aymanhab commented Feb 4, 2016

I tried to open the simple model bouncing_block from release 3.3 and it failed to open with
PointToPointSpring::connect() failed to connect ....

@aseth1
Copy link
Member

aseth1 commented Feb 4, 2016

@aymanhab In which build did you try to open the model? Is that model in the repository. Is there a test case for it? What was the complete error message? That will help track it down. Thanks!

@aymanhab
Copy link
Member Author

aymanhab commented Feb 4, 2016

@aseth1 This is occuring in my build of the GUI based off master before your last commit, so it may have been fixed. The model is from earlier distribution (3.3) and the error message is attached.
captureerrormsg

@aseth1
Copy link
Member

aseth1 commented Feb 4, 2016

Great. It's helpful to know that the component could not be found. It may be addressed by recent changes but it could also be due to a bug in the update from XML. Can you point me to the model file.
Thanks.

@aymanhab
Copy link
Member Author

aymanhab commented Feb 4, 2016

Sure, OpenSim3.3\Models\BouncingBlock\bouncing_block.osim Since we split the repositories, the model file doesn't live in the opensim-core repo.

@aseth1
Copy link
Member

aseth1 commented Feb 5, 2016

PointToPointSpring does not override updateFromXMLNode(). We should not spot fix this. Instead we should write a test to find all the Components that should be updated and we know it should find this one.

@tkuchida
Copy link
Member

From #1407:

Related to #206 (marked "Next Release"). We should have a folder of model files in all formats to rigorously exercise the updateFromXMLNode() methods in a dedicated test case…

@chrisdembia
Copy link
Member

PointToPointSpring does not override updateFromXMLNode(). We should not spot fix this. Instead we should write a test to find all the Components that should be updated and we know it should find this one.

Do you have an idea for how to write such a test? We at least need to add updateFromXMLNode() for PointToPointSpring before the release.

@chrisdembia
Copy link
Member

Perhaps we just need to just search the repo for each usage of the OpenSim_DECLARE_SOCKET macro.

@tkuchida
Copy link
Member

tkuchida commented Sep 8, 2017

From #1903: Move models, setup files, etc. to ${OPENSIM_SHARED_TEST_FILES_DIR} to avoid duplication of these files in the repo. Might need to add suffix to filename or make a subdirectory for each model version since there are several models with the same filename but different versions. It's valuable to maintain several versions of the same model to test the updateFromXMLNode() infrastructure.

@jenhicks jenhicks added this to the Icebox milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants