-
Notifications
You must be signed in to change notification settings - Fork 331
Add test case for model conversion #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@aymanhab Is this still an open issue (per your OpenSim 4.0 presentation)? |
Additional comment from @aseth1 In order to ensure that the content of older models is preserved they must be verified to contain the same content in the latest version of the model. |
I tried to open the simple model bouncing_block from release 3.3 and it failed to open with |
@aymanhab In which build did you try to open the model? Is that model in the repository. Is there a test case for it? What was the complete error message? That will help track it down. Thanks! |
@aseth1 This is occuring in my build of the GUI based off master before your last commit, so it may have been fixed. The model is from earlier distribution (3.3) and the error message is attached. |
Great. It's helpful to know that the component could not be found. It may be addressed by recent changes but it could also be due to a bug in the update from XML. Can you point me to the model file. |
Sure, OpenSim3.3\Models\BouncingBlock\bouncing_block.osim Since we split the repositories, the model file doesn't live in the opensim-core repo. |
PointToPointSpring does not override updateFromXMLNode(). We should not spot fix this. Instead we should write a test to find all the Components that should be updated and we know it should find this one. |
Do you have an idea for how to write such a test? We at least need to add |
Perhaps we just need to just search the repo for each usage of the |
From #1903: Move models, setup files, etc. to |
To make sure old models deserialize and display correctly, need a textual rep of Display and a suite of old models using old format.
The text was updated successfully, but these errors were encountered: