Split testCMCSingleMuscle into two to speed it up #1132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
|
(The test failure is the familiar testContactGeometry timeout on clang in Debug mode.) |
| cmc.run(); | ||
|
|
||
| Storage fwd_result("block_hanging_from_muscle_ForwardResults_Thelen/block_hanging_from_muscle_states.sto"); | ||
| Storage cmc_result("block_hanging_from_muscle_ResultsCMC_Thelen/block_hanging_from_muscle_states.sto"); |
There was a problem hiding this comment.
What's the issue here? How come changing the results directory caused an issue? Seems preferable.
There was a problem hiding this comment.
I understand now; you can ignore this comment.
|
These changes look correct. However I would feel more comfortable if the setup files |
|
Closing because #1146 makes splitting of the test unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1131 and #1127.