Skip to content

OCPBUGS-65544: add a relevant svc to the crio ports and missing contatier port to the machineconfig server daemonset #5463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Dec 10, 2025
Merged

OCPBUGS-65544: add a relevant svc to the crio ports and missing contatier port to the machineconfig server daemonset #5463

openshift-merge-bot merged 2 commits into from
Dec 10, 2025
+34 −1

Conversation

@aabughosh
Copy link
Contributor

@aabughosh aabughosh commented Dec 3, 2025 •
edited
Loading

  • add a relevant svc to the crio port
    port 9637 missing service so in this pr a service was added and a relevant label to the pods was added
  • add the missing container ports (22624 ,22623) ot he DaemonSet pods

@aabughosh
Copy link
Contributor Author

aabughosh commented Dec 3, 2025

/retest

1 similar comment
@aabughosh
Copy link
Contributor Author

aabughosh commented Dec 3, 2025

/retest

@yuqi-zhang yuqi-zhang changed the title add a relevant svc to the crio port OCPBUGS-65544: add a relevant svc to the crio port Dec 5, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 5, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 5, 2025

@aabughosh: This pull request references Jira Issue OCPBUGS-65544, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

add a relevant svc to the crio port

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr December 5, 2025 00:48
yuqi-zhang
yuqi-zhang reviewed Dec 5, 2025
View reviewed changes
@yuqi-zhang yuqi-zhang mentioned this pull request Dec 8, 2025
Closed
@aabughosh aabughosh changed the title OCPBUGS-65544: add a relevant svc to the crio port OCPBUGS-65544: add a relevant svc to the crio ports and missing contatier port to the machineconfig server daemonset Dec 9, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 9, 2025

@aabughosh: This pull request references Jira Issue OCPBUGS-65544, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • add a relevant svc to the crio port
    port 9637 missing service so in this pr a service was added and a relevant label to the pods was added
  • add the missing container ports (22624 ,22623) ot he DaemonSet pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aabughosh
Copy link
Contributor Author

aabughosh commented Dec 9, 2025

/retest

yuqi-zhang
yuqi-zhang approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label acknowledge-critical-fixes-only
/verified by @aabughosh

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 10, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aabughosh, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2025
@yuqi-zhang
Copy link
Contributor

yuqi-zhang commented Dec 10, 2025

/verified by @aabughosh

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 10, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2025

@yuqi-zhang: This PR has been marked as verified by @aabughosh.

In response to this:

/verified by @aabughosh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2025

/retest-required

Remaining retests: 0 against base HEAD 5e90221 and 2 for PR HEAD d41f4bb in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

@aabughosh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit d41f4bb link false /test bootstrap-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e2f6042 into openshift:main Dec 10, 2025
13 of 14 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2025

@aabughosh: Jira Issue OCPBUGS-65544 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

  • add a relevant svc to the crio port
    port 9637 missing service so in this pr a service was added and a relevant label to the pods was added
  • add the missing container ports (22624 ,22623) ot he DaemonSet pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aabughosh aabughosh mentioned this pull request Dec 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@dkhater-redhat dkhater-redhat Awaiting requested review from dkhater-redhat

@umohnani8 umohnani8 Awaiting requested review from umohnani8

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

Assignees

@yuqi-zhang yuqi-zhang

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aabughosh @openshift-ci-robot @yuqi-zhang