Skip to content

Conversation

@aabughosh
Copy link
Contributor

- What I did
Added hostIP: 127.0.0.1 to the machine-config-daemon container port 8798 in the DaemonSet manifest. This explicitly indicates that the health port is bound only to the localhost interface and is not externally exposed.

- Added `hostIP: 127.0.0.1` to the containerPort 8798 to explicitly indicate
  that the health port is only bound to localhost.
- Matches the existing behavior in logs:
    "Starting health listener on 127.0.0.1:8798"
  and address config: Addr: "127.0.0.1:8798"
- This is informational and clarifies that this port is not externally exposed.
@yuqi-zhang
Copy link
Contributor

Seems fine to me. Would this need to be backported? If not we can merge as no-jira, otherwise we should create a bug for it.

@aabughosh
Copy link
Contributor Author

Seems fine to me. Would this need to be backported? If not we can merge as no-jira, otherwise we should create a bug for it.

yes we need to backport

@aabughosh aabughosh changed the title Add hostIP 127.0.0.1 to machine-config-daemon port 8798 MCO-2000: Add hostIP 127.0.0.1 to machine-config-daemon port 8798 Dec 2, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 2, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

@aabughosh: This pull request references MCO-2000 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

- What I did
Added hostIP: 127.0.0.1 to the machine-config-daemon container port 8798 in the DaemonSet manifest. This explicitly indicates that the health port is bound only to the localhost interface and is not externally exposed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yuqi-zhang yuqi-zhang changed the title MCO-2000: Add hostIP 127.0.0.1 to machine-config-daemon port 8798 OCPBUGS-66314: Add hostIP 127.0.0.1 to machine-config-daemon port 8798 Dec 3, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 3, 2025
@openshift-ci-robot
Copy link
Contributor

@aabughosh: This pull request references Jira Issue OCPBUGS-66314, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did
Added hostIP: 127.0.0.1 to the machine-config-daemon container port 8798 in the DaemonSet manifest. This explicitly indicates that the health port is bound only to the localhost interface and is not externally exposed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

MCD pods look fine. Could you explain here or on the bug why this is needed and how to verify?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aabughosh, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2025
@aabughosh
Copy link
Contributor Author

checked the daemon pods
name: machine-config-daemon
ports:
- containerPort: 8798
hostIP: 127.0.0.1
hostPort: 8798
name: health
protocol: TCP
and this is the right behavior

@aabughosh
Copy link
Contributor Author

/verified by @aabughosh

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 3, 2025
@openshift-ci-robot
Copy link
Contributor

@aabughosh: This PR has been marked as verified by @aabughosh.

In response to this:

/verified by @aabughosh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aabughosh
Copy link
Contributor Author

/retest

1 similar comment
@aabughosh
Copy link
Contributor Author

/retest

@yuqi-zhang
Copy link
Contributor

/label acknowledge-critical-fixes-only

I believe this is critical to networking, so will apply this label. We believe this is safe to merge

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 3, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8e6beb0 and 2 for PR HEAD 3d32332 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5051cce and 1 for PR HEAD 3d32332 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2025

@aabughosh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit 3d32332 link false /test bootstrap-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9e2ecbb into openshift:main Dec 4, 2025
13 of 14 checks passed
@openshift-ci-robot
Copy link
Contributor

@aabughosh: Jira Issue Verification Checks: Jira Issue OCPBUGS-66314
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-66314 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

- What I did
Added hostIP: 127.0.0.1 to the machine-config-daemon container port 8798 in the DaemonSet manifest. This explicitly indicates that the health port is bound only to the localhost interface and is not externally exposed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.21.0-0.nightly-2025-12-08-112148

@aabughosh
Copy link
Contributor Author

/cherry-pick release-4.20

@openshift-cherrypick-robot

@aabughosh: new pull request created: #5474

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants