-
Notifications
You must be signed in to change notification settings - Fork 462
OCPBUGS-66314: Add hostIP 127.0.0.1 to machine-config-daemon port 8798 #5456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added `hostIP: 127.0.0.1` to the containerPort 8798 to explicitly indicate
that the health port is only bound to localhost.
- Matches the existing behavior in logs:
"Starting health listener on 127.0.0.1:8798"
and address config: Addr: "127.0.0.1:8798"
- This is informational and clarifies that this port is not externally exposed.
5dfcbd8 to
3d32332
Compare
|
Seems fine to me. Would this need to be backported? If not we can merge as no-jira, otherwise we should create a bug for it. |
yes we need to backport |
|
@aabughosh: This pull request references MCO-2000 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@aabughosh: This pull request references Jira Issue OCPBUGS-66314, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
yuqi-zhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
MCD pods look fine. Could you explain here or on the bug why this is needed and how to verify?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aabughosh, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
checked the daemon pods |
|
/verified by @aabughosh |
|
@aabughosh: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
1 similar comment
|
/retest |
|
/label acknowledge-critical-fixes-only I believe this is critical to networking, so will apply this label. We believe this is safe to merge |
|
@aabughosh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
9e2ecbb
into
openshift:main
|
@aabughosh: Jira Issue Verification Checks: Jira Issue OCPBUGS-66314 Jira Issue OCPBUGS-66314 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.21.0-0.nightly-2025-12-08-112148 |
|
/cherry-pick release-4.20 |
|
@aabughosh: new pull request created: #5474 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
- What I did
Added
hostIP: 127.0.0.1to themachine-config-daemoncontainer port 8798 in the DaemonSet manifest. This explicitly indicates that the health port is bound only to the localhost interface and is not externally exposed.