OCPBUGS-54975: Fix Cinder, Manila driver metrics #379
Conversation
We had configured the proxy sidecar container for the driver in the
controller Deployment, but the upstream it was pointing to did not
exist. Fix this by setting the --http-endpoint option. Per the upstream
docs [1]:
--http-endpoint <HTTP server>
This argument is optional.
The TCP network address where the HTTP server for providing metrics
for diagnostics, will listen (example: `:8080`).
The default is empty string, which means the server is disabled.
There's a bit of cleanup needed here to avoid hardcoding something which
is generated (via a loop-variable) elsewhere, but we'll do that
separately.
[1] https://github.com/kubernetes/cloud-provider-openstack/blob/release-1.32/docs/cinder-csi-plugin/using-cinder-csi-plugin.md#command-line-arguments
Signed-off-by: Stephen Finucane <[email protected]>
The openstack-manila driver does not currently support this. Signed-off-by: Stephen Finucane <[email protected]>
openshift-ci-robot
added
jira/valid-reference
|
@stephenfin: This pull request references Jira Issue OCPBUGS-54975, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@stephenfin: This pull request references Jira Issue OCPBUGS-54975, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required I haven't been able to reproduce the Cinder or Manila failures locally. Looks like an infra issue. |
|
/retest-required |
|
/test e2e-openstack |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
1 similar comment
|
@stephenfin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@stephenfin: Jira Issue OCPBUGS-54975: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-54975 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: csi-driver-manila-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-azure-disk-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-aws-efs-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: azure-file-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-aws-ebs-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-openstack-cinder-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-smb-csi-driver-operator |
|
/cherry-pick release-4.19 |
|
@stephenfin: #379 failed to apply on top of branch "release-4.18": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.19 |
|
@stephenfin: new pull request created: #386 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Modify the Cinder operator so that it starts reporting controller driver metrics correctly.
Modify the Manila operator so that we stop creating a controller driver metrics proxy container, since the controller driver does not currently support reporting metrics.