OCPBUGS-54447: Enable required driver services #369
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@dkokkino: This pull request references OSASINFRA-3748 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm hold for CI |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
Looking at the It also appears to be consistently failing at this step. This might be an environment issue but I wouldn't be so sure. This probably needs some local debugging. |
-Previously the service was enabled for both the node and controller simultaneously. This change makes sure the node-service is enabled on nodes and vise versa for the controller
dkokkino
force-pushed
the
OSASINFRA-3748
branch
from
ab3a399 to
6e2a414
Compare
|
/retest |
1 similar comment
|
/retest |
|
/unhold |
openshift-ci
bot
added
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkokkino, mpatlasov, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
The bot requires either a related bug in the OCPBUGS project, or someone adding the qe-approved label.
Not mergeable. Needs jira/valid-bug label OR Needs qe-approved label.
This looks like something we want to backport to 4.18, where we started using CSI operator for openstack CSI drivers, so most likely it would be better to move the OSASINFRA-3748 jira to the OCPBUGS project (to allow backporting if we need to).
|
/retitle OCPBUGS-54447: Enable required driver services |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-bug
|
@dkokkino: This pull request references Jira Issue OCPBUGS-54447, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.18 |
|
@mandre: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dkokkino: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@dkokkino: Jira Issue OCPBUGS-54447: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-54447 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mandre: new pull request created: #375 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-aws-efs-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-aws-ebs-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: azure-file-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: csi-driver-manila-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-azure-disk-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-smb-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-openstack-cinder-csi-driver-operator |
|
Fix included in accepted release 4.19.0-0.nightly-2025-04-02-065200 |
|
Fix included in accepted release 4.19.0-0.nightly-2025-04-02-170034 |
|
Fix included in accepted release 4.19.0-0.nightly-2025-04-04-023411 |
|
Fix included in accepted release 4.19.0-0.nightly-2025-04-04-170728 |
|
/cherry-pick release-4.18 This fixes merge conflicts for backports of #379 |
|
@stephenfin: new pull request could not be created: failed to create pull request against openshift/csi-operator#release-4.18 from head openshift-cherrypick-robot:cherry-pick-369-to-release-4.18: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-369-to-release-4.18."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Oh, #375 already exists. |
8 participants
The Manila CSI driver, like Cinder, uses a single binary for both the controller and node (worker) services. This can result in services running on unintended hosts. A similar issue was addressed in Cinder in version 4.18, and we should now apply the same fix to Manila.