Skip to content

CONSOLE-4772: Update list pages to use DataView in Workloads Tab #15653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CONSOLE-4772: Update list pages to use DataView in Workloads Tab #15653

wants to merge 3 commits into from
+926 −770

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Oct 28, 2025 •
edited
Loading

Includes changes from #15651, which should merge first.

Replaces #15489

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 28, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4772 which is a valid jira issue.

In response to this:

Includes changes from #15651, which should merge first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 28, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 28, 2025

/hold for #15651 to merge first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2025
@openshift-ci openshift-ci bot requested review from Leo6Leo and jhadvig October 28, 2025 19:27
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Oct 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin component/shared Related to console-shared component/topology Related to topology kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 28, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4772 which is a valid jira issue.

In response to this:

Includes changes from #15651, which should merge first.

Replaces #15489

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto rhamilto mentioned this pull request Oct 28, 2025
Closed
@rhamilto
Copy link
Member Author

rhamilto commented Oct 28, 2025

Adding labels as this is more of the same table migration work that has previously been approved.
/label docs-approved
/label px-approved

/assign @vojtechszocs
/assign @yapei

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Oct 28, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 29, 2025

/retest

@yapei
Copy link
Contributor

yapei commented Oct 29, 2025 •
edited
Loading

Add/Edit PodDisruptionBudget will return 404 page even though PDB can be successfully created/updated, other changes are working well

Add.Edit-PDB.mov

@rhamilto
Copy link
Member Author

rhamilto commented Oct 29, 2025

Add/Edit PodDisruptionBudget will return 404 page even though PDB can be successfully created/updated, other changes are working well

Add.Edit-PDB.mov

Good catch, @yapei! I am fairly certain that bug is due to changes made by @logonoff in #15620 with an attempt to fix with #15651 (in other words, that bug is unrelated to the changes in this PR that are not part of #15651).

@logonoff, I confirmed by checking out https://github.com/openshift/console/tree/6b6b09064b25455d86b938a2cb0e8d4da6f48071 and confirming the bug does not exist there.

@rhamilto
Copy link
Member Author

rhamilto commented Oct 29, 2025

/retest

1 similar comment
@rhamilto
Copy link
Member Author

rhamilto commented Oct 29, 2025

/retest

@yapei
Copy link
Contributor

yapei commented Oct 30, 2025

approve this PR since PR scope changes are working well
/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 30, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 30, 2025

@yapei: This PR has been marked as verified by @yapei.

In response to this:

approve this PR since PR scope changes are working well
/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yapei yapei mentioned this pull request Oct 30, 2025
Merged
@jhadvig
Copy link
Member

jhadvig commented Nov 5, 2025

#15651 got merged
/hold cancel

/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Nov 5, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhamilto rhamilto added the plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer label Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@vojtechszocs vojtechszocs

@yapei yapei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rhamilto @openshift-ci-robot @yapei @jhadvig @vojtechszocs @logonoff