CONSOLE-4772: Update list pages to use DataView in Workloads Tab #15489

krishagarwal278 · 2025-09-12T18:00:36Z

Updated CRD list pages(secret, deployment, deployment-config, daemon-set, PDB, configmap) in workloads

workloads.1.mp4

Note: I've only updated modals in this PR because of failing integration tests due to a conflict when pulling the useOverlay Hook story work

openshift-ci-robot · 2025-09-12T18:00:41Z

@krishagarwal278: This pull request references CONSOLE-4772 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Modified the Secrets.jsx
https://github.com/user-attachments/assets/4c298b8d-6953-483c-be8c-08f2834c5932

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

frontend/public/components/secret.jsx

rhamilto · 2025-09-12T18:10:56Z

frontend/public/components/secret.jsx

-    </>
-  );
+    const rowCells = {
+      name: {


Deduplicate the keys by pulling them out to a separate array of objects.

frontend/public/components/secret.jsx

openshift-ci-robot · 2025-09-12T19:34:03Z

@krishagarwal278: This pull request references CONSOLE-4772 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Modified Secrets.jsx

488963068-4c298b8d-6953-483c-be8c-08f2834c5932.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

frontend/public/components/secret.jsx

krishagarwal278 · 2025-09-15T14:32:42Z

/retest

openshift-ci-robot · 2025-09-18T02:37:40Z

@krishagarwal278: This pull request references CONSOLE-4772 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Updated CRD list pages(secret, deployment, deployment-config, configmap) in workloads

workloads.1.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2025-10-23T13:17:56Z

/retest-required

Seems flaky from the error log.

rhamilto · 2025-10-23T14:52:44Z

frontend/packages/integration-tests-cypress/tests/crud/resource-crud.cy.ts

+    skipYamlReloadTest: true,
+    skipYamlSaveTest: true,
+  });
+  // .set('buildconfigs', {


Still needed

rhamilto · 2025-10-23T14:53:23Z

frontend/packages/integration-tests-cypress/tests/app/filtering-and-searching.cy.ts

  });

-  // disabled as listPage.rows.shouldExist isn't a valid test
+  // disabled as listPage.dvRows.shouldExist isn't a valid test


The code below didn't get updated, so this comment update is unnecessary.

rhamilto · 2025-10-23T15:00:24Z

frontend/packages/console-app/locales/en/console-app.json

  "Create {{label}}": "Create {{label}}",
  "Edit {{label}}": "Edit {{label}}",
  "{helpText}": "{helpText}",
+  "Disruptions allowed": "Disruptions allowed",


This new string is indicative there are unintended changes somewhere.

This change came as part of my discussion with @jseseCCS on improving user texts. The updates to user-texts are part of this commit: 92bacc7

rhamilto · 2025-10-23T15:01:20Z

frontend/packages/console-app/src/components/pdb/PDBList.tsx

-import { useActiveColumns } from '@console/internal/components/factory/Table/active-columns-hook';
-import VirtualizedTable from '@console/internal/components/factory/Table/VirtualizedTable';
-import { getPDBTableColumns } from './pdb-table-columns';
-import PodDisruptionBudgetTableRow from './PDBTableRow';


If the existing row is shared, we want to maintain that sharing.

okay, i'll import and apply https://github.com/openshift/console/blob/main/frontend/packages/console-app/src/components/pdb/pdb-table-columns.tsx in the new table implementation. Won't be changing cell contents since it's out of scope 👍🏻

rhamilto · 2025-10-23T15:01:38Z

frontend/packages/console-app/src/components/pdb/PDBList.tsx

+
+const usePDBColumns = (): TableColumn<PodDisruptionBudgetKind>[] => {
  const { t } = useTranslation();
-  const [columns] = useActiveColumns({ columns: getPDBTableColumns() });


We want to keep column management.

rhamilto · 2025-10-23T15:36:03Z

frontend/packages/integration-tests-cypress/tests/app/filtering-and-searching.cy.ts

      qs: { kind: 'Pod', q: 'app=name', name: WORKLOAD_NAME },
    });
-    listPage.rows.shouldExist(WORKLOAD_NAME);
+    listPage.dvRows.shouldExist(WORKLOAD_NAME);


This test is disabled, so no need to update.

rhamilto · 2025-10-23T15:37:12Z

frontend/packages/integration-tests-cypress/tests/app/start-job-from-cronjob.cy.ts

+    listPage.dvRows.shouldBeLoaded();
    cy.visit(`/k8s/ns/${testName}/cronjobs/${CRONJOB_NAME}/jobs`);
-    listPage.dvRows.countShouldBe(2);
+    listPage.rows.countShouldBe(2);


jobs list was already updated, so this change is gonna break the test.

rhamilto · 2025-10-23T15:38:07Z

frontend/public/components/configmap.tsx

+        cell: <ResourceLink kind="Namespace" name={namespace} />,
+      },
+      [tableColumnInfo[2].id]: {
+        cell: <span>{dataSize}</span>,


This is incorrect.

removed <span/> tag

Removing the unnecessary <span> is great! But it looks like the value of this cell changed from {_.size(configMap.data) + _.size(configMap.binaryData)} to sorts.dataSize(configMap).

the correct calculation for dataSize is in table.tsx:
https://github.com/openshift/console/blob/main/frontend/public/components/factory/table.tsx#L64

i am importing sort from './factory/table' and applying sorts.dataSize to the cell

rhamilto · 2025-10-23T16:50:44Z

frontend/public/components/cron-job.tsx

+        cell: <ResourceLink kind="Namespace" name={namespace} />,
+      },
+      [tableColumnInfo[2].id]: {
+        cell: <span>{cronjob.spec.schedule}</span>,


Contents are not the same as before. I'm gonna stop reviewing here and have you double check the rest of the files.

…ap, cronjob, PDBList, daemon-set)in workloads modified: frontend/packages/console-app/src/components/data-view/ResourceDataView.tsx modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-cli-download.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-notification.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-yaml-sample.cy.ts modified: frontend/public/components/configmap.tsx modified: frontend/public/components/deployment-config.tsx modified: frontend/public/components/deployment.tsx modified: frontend/public/components/factory/list-page.tsx modified: frontend/public/components/filter-toolbar.tsx modified: frontend/public/components/secret.tsx

modified: frontend/public/components/cron-job.tsx modified: frontend/public/components/secret.tsx modified: frontend/public/locales/en/public.json

modified: frontend/packages/integration-tests-cypress/tests/crud/namespace-crud.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crud/resource-crud.cy.ts modified: frontend/packages/integration-tests-cypress/views/list-page.ts modified: frontend/public/components/daemon-set.tsx modified: frontend/public/locales/en/public.json modified: frontend/packages/integration-tests-cypress/tests/crud/namespace-crud.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crud/resource-crud.cy.ts modified: frontend/packages/integration-tests-cypress/views/list-page.ts modified: frontend/public/components/daemon-set.tsx modified: frontend/public/locales/en/public.json

…orkload-table.tsx modified: frontend/packages/console-app/src/components/data-view/ResourceDataView.tsx modified: frontend/packages/console-app/src/components/pdb/PDBList.tsx modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-cli-download.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-external-log-link.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-link.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-notification.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-yaml-sample.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crud/namespace-crud.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crud/resource-crud.cy.ts modified: frontend/packages/integration-tests-cypress/views/list-page.ts modified: frontend/public/components/configmap.tsx modified: frontend/public/components/cron-job.tsx modified: frontend/public/components/daemon-set.tsx modified: frontend/public/components/deployment-config.tsx modified: frontend/public/components/deployment.tsx modified: frontend/public/components/secret.tsx modified: frontend/public/components/workload-table.tsx modified: frontend/public/locales/en/public.json modified: frontend/packages/console-app/src/components/pdb/PDBList.tsx modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-cli-download.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-external-log-link.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-link.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-notification.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-yaml-sample.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crud/namespace-crud.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crud/resource-crud.cy.ts modified: frontend/packages/integration-tests-cypress/views/list-page.ts modified: frontend/public/components/configmap.tsx modified: frontend/public/components/cron-job.tsx modified: frontend/public/components/daemon-set.tsx modified: frontend/public/components/deployment-config.tsx modified: frontend/public/components/deployment.tsx modified: frontend/public/components/secret.tsx modified: frontend/public/components/workload-table.tsx modified: frontend/public/locales/en/public.json

…d-table.tsx

modified: frontend/public/components/modals/expand-pvc-modal.tsx

modified: frontend/packages/integration-tests-cypress/tests/app/demo-dynamic-plugin.cy.ts modified: frontend/packages/integration-tests-cypress/tests/app/deployments.cy.ts modified: frontend/packages/integration-tests-cypress/tests/app/filtering-and-searching.cy.ts modified: frontend/packages/integration-tests-cypress/tests/app/start-job-from-cronjob.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-cli-download.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-external-log-link.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-notification.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crd-extensions/console-yaml-sample.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crud/resource-crud.cy.ts modified: frontend/packages/integration-tests-cypress/views/list-page.ts modified: frontend/public/components/configmap.tsx modified: frontend/public/components/daemon-set.tsx modified: frontend/public/components/workload-table.tsx modified: frontend/public/locales/en/public.json

krishagarwal278 · 2025-10-28T13:04:20Z

/retest

openshift-ci · 2025-10-28T16:52:00Z

@krishagarwal278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	`2ab51b4`	link	true	`/test e2e-gcp-console`
ci/prow/okd-scos-e2e-aws-ovn	`2ab51b4`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rhamilto · 2025-10-28T19:28:30Z

Replaced by #15653

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2025

openshift-ci bot requested review from Leo6Leo and TheRealJon September 12, 2025 18:00

openshift-ci bot added component/core Related to console core functionality kind/cypress Related to Cypress e2e integration testing labels Sep 12, 2025