-
Notifications
You must be signed in to change notification settings - Fork 663
CONSOLE-4806: Remove static extensions from knative-plugin #15641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
8f5dc89
abbb2b4
18fba13
0dbd7a8
d16dafe
395122d
d28fbd5
dcf0f44
9a51df4
5b83c8a
96cb737
e733bb8
d204174
6ec040b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2008,5 +2008,71 @@ | |
| "flags": { | ||
| "required": ["KNATIVE_EVENTING"] | ||
| } | ||
| }, | ||
| { | ||
| "type": "console.topology/data/factory", | ||
| "properties": { | ||
| "id": "knative-serving-topology-model-factory", | ||
| "priority": 100, | ||
| "resources": { | ||
| "$codeRef": "getKnativeResources.getKnativeServingResources" | ||
| }, | ||
| "workloadKeys": ["ksservices"], | ||
| "getDataModel": { | ||
| "$codeRef": "dataTransformer.getKnativeServingTopologyDataModel" | ||
| }, | ||
| "isResourceDepicted": { | ||
| "$codeRef": "isKnativeResource.isKnativeResource" | ||
| } | ||
| }, | ||
| "flags": { | ||
| "required": [ | ||
| "KNATIVE_SERVING_CONFIGURATION", | ||
| "KNATIVE_SERVING", | ||
| "KNATIVE_SERVING_REVISION", | ||
| "KNATIVE_SERVING_ROUTE", | ||
| "KNATIVE_SERVING_SERVICE" | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "type": "console.topology/data/factory", | ||
| "properties": { | ||
| "id": "knative-eventing-topology-model-factory", | ||
| "priority": 100, | ||
| "resources": { | ||
| "$codeRef": "getKnativeResources.getKnativeEventingResources" | ||
| }, | ||
|
Comment on lines
+2062
to
+2064
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. resources expects a The challenge of this ticket is that We discussed in the dynamic plugin sync that this coderef should be typed with resources: The promise is needed as plugins may want to do some fetching in order to determine which k8s resources should be wtached. This will require changes to any code which consumes the This API change is already approved by @spadgett so you will get |
||
| "workloadKeys": ["eventingsubscription"], | ||
| "getDataModel": { | ||
| "$codeRef": "dataTransformer.getKnativeEventingTopologyDataModel" | ||
| }, | ||
| "isResourceDepicted": { | ||
| "$codeRef": "isKnativeResource.isKnativeResource" | ||
| } | ||
| }, | ||
| "flags": { | ||
| "required": ["KNATIVE_EVENTING", "FLAG_KNATIVE_EVENTING_ENABLED"] | ||
| } | ||
| }, | ||
| { | ||
| "type": "console.topology/data/factory", | ||
| "properties": { | ||
| "id": "knative-kamelets-topology-model-factory", | ||
| "priority": 100, | ||
| "resources": { | ||
| "$codeRef": "getKnativeResources.getKnativeEventingKameletsResources" | ||
| }, | ||
|
Comment on lines
2082
to
2099
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. resources expects a
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also since getKnativeEventingKameletsResources always returns the same object we can embed the contents of that directly into the json file--no codeRef needed |
||
| "workloadKeys": ["kameletbindings"], | ||
| "getDataModel": { | ||
| "$codeRef": "dataTransformer.getKnativeKameletsTopologyDataModel" | ||
| }, | ||
| "isResourceDepicted": { | ||
| "$codeRef": "isKnativeResource.isKnativeResource" | ||
| } | ||
| }, | ||
| "flags": { | ||
| "required": ["KNATIVE_EVENTING", "FLAG_CAMEL_KAMELETS"] | ||
| } | ||
| } | ||
| ] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| // See console-extensions.json instead | ||
| export default []; |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resources expects a
WatchK8sResourcesGenericand not a codeRefUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also since getKnativeServingResources always returns the same object we can embed the contents of that directly into the json file--no codeRef needed