CONSOLE-4806: Remove static extensions from knative-plugin #15641

Leo6Leo · 2025-10-24T14:25:27Z

Description

As a part of the alignment of OpenShift console's dynamic plugin sdk and the OpenShift dynamic plugin sdk, we want to get rid of the long-standing legacy "static plugin" API which is still used in console.

To do this, we can gradually migrate each "static plugin extension" to the equivalent "dynamic extension". This ensures better alignment of web console code with its own SDK.

AC: All static extension in the plugin mentioned in the ticket name is removed and replaced with the dynamic counterpart

…ate console-extensions.json to include new topology data model factories for serving, eventing, and kamelets, and remove deprecated topology-plugin.ts file

openshift-ci-robot · 2025-10-24T14:25:31Z

@Leo6Leo: This pull request references CONSOLE-4806 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Description

As a part of the alignment of OpenShift console's dynamic plugin sdk and the OpenShift dynamic plugin sdk, we want to get rid of the long-standing legacy "static plugin" API which is still used in console.

To do this, we can gradually migrate each "static plugin extension" to the equivalent "dynamic extension". This ensures better alignment of web console code with its own SDK.

AC: All static extension in the plugin mentioned in the ticket name is removed and replaced with the dynamic counterpart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-10-24T14:36:52Z

frontend/packages/knative-plugin/console-extensions.json

+      "resources": {
+        "$codeRef": "getKnativeResources.getKnativeServingResources"
+      },


resources expects a WatchK8sResourcesGeneric and not a codeRef

also since getKnativeServingResources always returns the same object we can embed the contents of that directly into the json file--no codeRef needed

logonoff · 2025-10-24T14:39:18Z

frontend/packages/knative-plugin/console-extensions.json

+      "resources": {
+        "$codeRef": "getKnativeResources.getKnativeEventingResources"
+      },


resources expects a WatchK8sResourcesGeneric and not a codeRef.

The challenge of this ticket is that getKnativeEventingResources is dynamic, so we need to modify console.topology/data/factory to also allow codeRefs.

We discussed in the dynamic plugin sync that this coderef should be typed with

resources: WatchK8sResourcesGeneric | CodeRef<() => Promise<WatchK8sResourcesGeneric>>.

The promise is needed as plugins may want to do some fetching in order to determine which k8s resources should be wtached.

This will require changes to any code which consumes the TopologyDataModelFactory extension. I suggest possibly writing a useTopologyDataModelFactory hook in the topology package to allow resolve the codeRefs

This API change is already approved by @spadgett so you will get plugin-api-approved with this change

logonoff · 2025-10-24T14:39:25Z

frontend/packages/knative-plugin/console-extensions.json

+      "resources": {
+        "$codeRef": "getKnativeResources.getKnativeEventingKameletsResources"
+      },


resources expects a WatchK8sResourcesGeneric and not a codeRef.

also since getKnativeEventingKameletsResources always returns the same object we can embed the contents of that directly into the json file--no codeRef needed

jhadvig

Nice job @Leo6Leo 👍

/lgtm
/approve

Leo6Leo · 2025-10-24T15:58:30Z

/hold for addressing the PR review from @logonoff

…static-extensions-from-knative-plugin/main

Enable dynamic plugin extensions to use CodeRef for the resources property in topology data model factories. This allows plugins to fetch resources dynamically at runtime (e.g., discovering CRDs). Changes: - Update TopologyDataModelFactory type to accept CodeRef<() => Promise<WatchK8sResourcesGeneric>> - Add Promise resolution in DataModelExtension for CodeRef resources - Update get-knative-resources functions to return Promises with resource definitions - Maintain backward compatibility with static resource definitions The implementation follows the same pattern as other CodeRef properties (getDataModel, isResourceDepicted) by resolving the Promise eagerly during extension initialization and caching the result. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

logonoff

nice!

frontend/packages/knative-plugin/src/utils/get-knative-resources.ts

logonoff · 2025-10-28T18:40:02Z

frontend/packages/topology/src/hooks/useTopologyDataModelFactory.ts

+ * Resources type that can be:
+ * 1. Static WatchK8sResourcesGeneric (from dynamic plugin SDK)
+ * 2. CodeRef<() => Promise<WatchK8sResourcesGeneric>> (from dynamic plugin SDK, for dynamic resources)
+ * 3. Function (namespace: string) => WatchK8sResources (from old internal plugin system or converted dynamic plugins)


we should only be supporting 1 and 2, this really should be TopologyDataModelFactory.properties.resources.

you can build on my PR, #15617, which removes the final usage of TopologyDataModelFacotry. then we no longer care about its support

Once #15617 merges, I will clean up the DataModelProvider to remove the old modelFactories usage.

FYI this PR has merged

logonoff · 2025-10-28T18:42:45Z

frontend/packages/topology/src/data-transforms/DataModelProvider.tsx

+      return {
+        ...extension,
+        properties: {
+          ...extension.properties,
+          // Keep the original CodeRef - it will be resolved by useResolvedResources hook
+          resources,
+        },
+      };


doesn't this just return extension?

Co-authored-by: logonoff <[email protected]>

…ic definitions Replaces dynamic CodeRef-based resource definitions with inline static definitions for knative-serving and kamelets topology model factories, removing the need for runtime resolution. Adds compatibility layer for converting dynamic model factories to internal plugin format. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

…static-extensions-from-knative-plugin/main

Leo6Leo · 2025-11-03T14:42:55Z

/retest

logonoff

/lgtm

I guess our prettier/eslint setup is too old for satisfies... 🤷

openshift-ci · 2025-11-03T19:12:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, Leo6Leo, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [jhadvig,logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…static-extensions-from-knative-plugin/main

openshift-ci · 2025-11-03T19:43:45Z

New changes are detected. LGTM label has been removed.

Refactor topology package to remove static extension support and rely exclusively on dynamic plugin SDK for topology data model factories. Key changes: - Remove TopologyDataModelFactory extension interface and related types - Simplify ApplicationDropdown to use only base watched resources - Remove legacy function format support in useTopologyDataModelFactory - Eliminate conversion layer between dynamic and static factories - Update DataModelProvider to handle only dynamic extensions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

frontend/packages/knative-plugin/src/utils/get-knative-resources.ts

frontend/packages/topology/src/data-transforms/DataModelProvider.tsx

frontend/packages/topology/src/extensions/topology.ts

logonoff · 2025-11-03T21:13:42Z

frontend/packages/topology/src/hooks/useTopologyDataModelFactory.ts

+    if (typeof resources === 'function') {
+      // CodeRef format: CodeRef<() => Promise<WatchK8sResourcesGeneric>>
+      // which is a function that returns Promise<() => Promise<WatchK8sResourcesGeneric>>
+      setLoading(true);
+      const fetchResources = async () => {


if the initial code that fetches TopologyResourcesType uses instead useResolvedExtensions, the resolution of the CodeRef is done automatically for us.

We can then also type the param resources as resources: ResolvedExtension<TopologyDataModelFactory>['resources']

frontend/packages/topology/src/data-transforms/DataModelExtension.tsx

logonoff · 2025-11-03T21:18:49Z

frontend/packages/topology/src/data-transforms/DataModelExtension.tsx

+/**
+ * Converts a single resource from WatchK8sResourcesGeneric format to WatchK8sResource format.
+ * This handles the namespace injection and model reference resolution.
+ */
+const convertGenericResource = (
+  namespace: string,
+  model?: { group?: string; version?: string; kind: string },
+  opts?: Partial<WatchK8sResource>,
+): WatchK8sResource | null => {
+  if (!model) {
+    return { namespace, ...opts };
+  }
+
+  // Try to find the internal model
+  const internalModel = modelForGroupKind(model.group, model.kind);
+  if (!internalModel) {
+    // CRD not found - log warning and skip
+    // eslint-disable-next-line no-console
+    console.warn(
+      `Could not find model (CRD) for group "${model.group}" and kind "${model.kind}". Resource will be skipped.`,
+    );
+    return null;
+  }


is this needed to work? my understanding was that WatchK8sResourcesGeneric allows you to provide all the options that WatchK8sResource does

logonoff · 2025-11-03T21:19:27Z

/label tide/merge-method-squash

…static-extensions-from-knative-plugin/main

Co-authored-by: logonoff <[email protected]>

…es.ts Co-authored-by: logonoff <[email protected]>

Replace custom useResolvedResources hook with built-in useResolvedExtensions to simplify the topology data model extension handling. This removes the need for manual CodeRef resolution and improves error messaging with plugin context. Changes: - Use useResolvedExtensions instead of useExtensions in DataModelProvider - Remove useTopologyDataModelFactory hook (no longer needed) - Simplify DataModelExtension to work with pre-resolved extensions - Add plugin ID to error messages for better debugging - Use referenceForExtensionModel for better CRD reference resolution 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

openshift-ci · 2025-11-06T02:12:00Z

@Leo6Leo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	`6ec040b`	link	true	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

feat: Refactor Knative plugin: replace plugin.tsx with plugin.ts, upd…

8f5dc89

…ate console-extensions.json to include new topology data model factories for serving, eventing, and kamelets, and remove deprecated topology-plugin.ts file

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 24, 2025

openshift-ci bot requested review from TheRealJon and spadgett October 24, 2025 14:25

openshift-ci bot added the component/knative Related to knative-plugin label Oct 24, 2025

logonoff reviewed Oct 24, 2025

View reviewed changes

jhadvig approved these changes Oct 24, 2025

View reviewed changes

openshift-ci bot assigned jhadvig Oct 24, 2025

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 24, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2025

Leo6Leo and others added 2 commits October 28, 2025 11:38

Merge remote-tracking branch 'upstream' into leo/ocpbugs/4806/Remove-…

abbb2b4

…static-extensions-from-knative-plugin/main

openshift-ci bot added component/sdk Related to console-plugin-sdk component/topology Related to topology plugin-api-changed Categorizes a PR as containing plugin API changes and removed lgtm Indicates that a PR is ready to be merged. labels Oct 28, 2025

openshift-ci bot assigned spadgett and vojtechszocs Oct 28, 2025

logonoff reviewed Oct 28, 2025

View reviewed changes

Leo6Leo and others added 4 commits October 28, 2025 15:01

Apply suggestions from code review

0dbd7a8

Co-authored-by: logonoff <[email protected]>

fix: fix the review comments from @logonoff

d16dafe

Merge remote-tracking branch 'upstream' into leo/ocpbugs/4806/Remove-…

d28fbd5

…static-extensions-from-knative-plugin/main

logonoff reviewed Nov 3, 2025

View reviewed changes

openshift-ci bot assigned logonoff Nov 3, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025

Merge remote-tracking branch 'upstream' into leo/ocpbugs/4806/Remove-…

dcf0f44

…static-extensions-from-knative-plugin/main

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025

Leo6Leo requested a review from logonoff November 3, 2025 20:41

logonoff reviewed Nov 3, 2025

View reviewed changes

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 3, 2025

jhadvig added the plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer label Nov 4, 2025

Leo6Leo and others added 5 commits November 4, 2025 16:19

Merge remote-tracking branch 'upstream' into leo/ocpbugs/4806/Remove-…

5b83c8a

…static-extensions-from-knative-plugin/main

Apply suggestions from code review

96cb737

Co-authored-by: logonoff <[email protected]>

Update frontend/packages/knative-plugin/src/utils/get-knative-resourc…

e733bb8

…es.ts Co-authored-by: logonoff <[email protected]>

fix: Refactor DataModelExtension to streamline resource conversion

6ec040b

CONSOLE-4806: Remove static extensions from knative-plugin #15641

Are you sure you want to change the base?

CONSOLE-4806: Remove static extensions from knative-plugin #15641

Uh oh!

Conversation

Leo6Leo commented Oct 24, 2025

Description

Uh oh!

openshift-ci-robot commented Oct 24, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

logonoff Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

logonoff Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

Leo6Leo commented Oct 24, 2025

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Leo6Leo commented Nov 3, 2025

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 3, 2025

Uh oh!

openshift-ci bot commented Nov 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

logonoff Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

logonoff commented Nov 3, 2025

Uh oh!

openshift-ci bot commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-ci-robot commented Oct 24, 2025 •

edited by openshift-ci bot

Loading

logonoff Oct 30, 2025 •

edited

Loading

logonoff Oct 24, 2025 •

edited

Loading

logonoff Nov 3, 2025 •

edited

Loading