CONSOLE-4806: Remove static extensions from knative-plugin #15641

Leo6Leo · 2025-10-24T14:25:27Z

Description

As a part of the alignment of OpenShift console's dynamic plugin sdk and the OpenShift dynamic plugin sdk, we want to get rid of the long-standing legacy "static plugin" API which is still used in console.

To do this, we can gradually migrate each "static plugin extension" to the equivalent "dynamic extension". This ensures better alignment of web console code with its own SDK.

AC: All static extension in the plugin mentioned in the ticket name is removed and replaced with the dynamic counterpart

…ate console-extensions.json to include new topology data model factories for serving, eventing, and kamelets, and remove deprecated topology-plugin.ts file

openshift-ci-robot · 2025-10-24T14:25:31Z

@Leo6Leo: This pull request references CONSOLE-4806 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Description

As a part of the alignment of OpenShift console's dynamic plugin sdk and the OpenShift dynamic plugin sdk, we want to get rid of the long-standing legacy "static plugin" API which is still used in console.

To do this, we can gradually migrate each "static plugin extension" to the equivalent "dynamic extension". This ensures better alignment of web console code with its own SDK.

AC: All static extension in the plugin mentioned in the ticket name is removed and replaced with the dynamic counterpart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-10-24T14:36:52Z

frontend/packages/knative-plugin/console-extensions.json

+      "resources": {
+        "$codeRef": "getKnativeResources.getKnativeServingResources"
+      },


resources expects a WatchK8sResourcesGeneric and not a codeRef

also since getKnativeServingResources always returns the same object we can embed the contents of that directly into the json file--no codeRef needed

logonoff · 2025-10-24T14:39:18Z

frontend/packages/knative-plugin/console-extensions.json

+      "resources": {
+        "$codeRef": "getKnativeResources.getKnativeEventingResources"
+      },


resources expects a WatchK8sResourcesGeneric and not a codeRef.

The challenge of this ticket is that getKnativeEventingResources is dynamic, so we need to modify console.topology/data/factory to also allow codeRefs.

We discussed in the dynamic plugin sync that this coderef should be typed with

resources: WatchK8sResourcesGeneric | CodeRef<() => Promise<WatchK8sResourcesGeneric>>.

The promise is needed as plugins may want to do some fetching in order to determine which k8s resources should be wtached.

This will require changes to any code which consumes the TopologyDataModelFactory extension. I suggest possibly writing a useTopologyDataModelFactory hook in the topology package to allow resolve the codeRefs

This API change is already approved by @spadgett so you will get plugin-api-approved with this change

logonoff · 2025-10-24T14:39:25Z

frontend/packages/knative-plugin/console-extensions.json

+      "resources": {
+        "$codeRef": "getKnativeResources.getKnativeEventingKameletsResources"
+      },


resources expects a WatchK8sResourcesGeneric and not a codeRef.

also since getKnativeEventingKameletsResources always returns the same object we can embed the contents of that directly into the json file--no codeRef needed

jhadvig

Nice job @Leo6Leo 👍

/lgtm
/approve

Leo6Leo · 2025-10-24T15:58:30Z

/hold for addressing the PR review from @logonoff

…static-extensions-from-knative-plugin/main

Enable dynamic plugin extensions to use CodeRef for the resources property in topology data model factories. This allows plugins to fetch resources dynamically at runtime (e.g., discovering CRDs). Changes: - Update TopologyDataModelFactory type to accept CodeRef<() => Promise<WatchK8sResourcesGeneric>> - Add Promise resolution in DataModelExtension for CodeRef resources - Update get-knative-resources functions to return Promises with resource definitions - Maintain backward compatibility with static resource definitions The implementation follows the same pattern as other CodeRef properties (getDataModel, isResourceDepicted) by resolving the Promise eagerly during extension initialization and caching the result. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

logonoff

nice!

frontend/packages/knative-plugin/src/utils/get-knative-resources.ts

logonoff · 2025-10-28T18:40:02Z

frontend/packages/topology/src/hooks/useTopologyDataModelFactory.ts

+ * Resources type that can be:
+ * 1. Static WatchK8sResourcesGeneric (from dynamic plugin SDK)
+ * 2. CodeRef<() => Promise<WatchK8sResourcesGeneric>> (from dynamic plugin SDK, for dynamic resources)
+ * 3. Function (namespace: string) => WatchK8sResources (from old internal plugin system or converted dynamic plugins)


we should only be supporting 1 and 2, this really should be TopologyDataModelFactory.properties.resources.

you can build on my PR, #15617, which removes the final usage of TopologyDataModelFacotry. then we no longer care about its support

Once #15617 merges, I will clean up the DataModelProvider to remove the old modelFactories usage.

FYI this PR has merged

logonoff · 2025-10-28T18:42:45Z

frontend/packages/topology/src/data-transforms/DataModelProvider.tsx

+      return {
+        ...extension,
+        properties: {
+          ...extension.properties,
+          // Keep the original CodeRef - it will be resolved by useResolvedResources hook
+          resources,
+        },
+      };


doesn't this just return extension?

Co-authored-by: logonoff <[email protected]>

…ic definitions Replaces dynamic CodeRef-based resource definitions with inline static definitions for knative-serving and kamelets topology model factories, removing the need for runtime resolution. Adds compatibility layer for converting dynamic model factories to internal plugin format. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

…static-extensions-from-knative-plugin/main

Leo6Leo · 2025-11-03T14:42:55Z

/retest

logonoff

/lgtm

I guess our prettier/eslint setup is too old for satisfies... 🤷

…taModelProvider

logonoff · 2025-11-13T16:59:11Z

/unhold
/retitle CONSOLE-4806: Remove static extensions from knative-plugin

logonoff

/lgtm

logonoff · 2025-11-13T17:01:07Z

/assign @yapei

logonoff · 2025-11-13T17:05:40Z

/label px-approved
/label docs-approved

openshift-ci · 2025-11-13T17:10:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, Leo6Leo, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [jhadvig,logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

logonoff · 2025-11-15T16:58:04Z

/retest

Leo6Leo · 2025-11-17T01:41:42Z

/retest-required

yapei · 2025-11-17T08:17:39Z

frontend/packages/topology/src/components/dropdowns/ApplicationDropdown.tsx

      prop: key,
    }));
-  }, [namespacedDynamicFactories, modelFactories, namespace]);
+  }, [namespace]);


Sometimes, the Application dropdown will got reset back to All applications

reset.mov

I think this is related to https://issues.redhat.com/browse/OCPBUGS-62713 ?

you are right!

yapei · 2025-11-17T08:24:59Z

frontend/packages/topology/src/components/dropdowns/ApplicationDropdown.tsx

      prop: key,
    }));
-  }, [namespacedDynamicFactories, modelFactories, namespace]);
+  }, [namespace]);


this issue is also reproducible on 420 nightly, not sure whether the fix should be part of PR scope?

yapei · 2025-11-17T08:38:13Z

performed other regression testings about

Serverless -> Serving, Eventing, Functions pages
Knative resources in Topology view, resource sidebar
No regression issues found

yapei · 2025-11-18T01:08:35Z

no new issues during PR testing
/verified by @yapei

openshift-ci-robot · 2025-11-18T01:08:47Z

@yapei: This PR has been marked as verified by @yapei.

In response to this:

no new issues during PR testing
/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-18T07:54:56Z

/retest-required

Remaining retests: 0 against base HEAD 1fe9940 and 2 for PR HEAD 726f09e in total

openshift-ci-robot · 2025-11-18T13:54:39Z

/retest-required

Remaining retests: 0 against base HEAD f0cb82b and 1 for PR HEAD 726f09e in total

Leo6Leo · 2025-11-18T14:23:08Z

/retest

logonoff · 2025-11-18T17:41:44Z

/retest

openshift-ci · 2025-11-18T21:41:22Z

@Leo6Leo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	`726f09e`	link	true	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

logonoff · 2025-11-18T21:51:59Z

/retest

feat: Refactor Knative plugin: replace plugin.tsx with plugin.ts, upd…

8f5dc89

…ate console-extensions.json to include new topology data model factories for serving, eventing, and kamelets, and remove deprecated topology-plugin.ts file

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 24, 2025

openshift-ci bot requested review from TheRealJon and spadgett October 24, 2025 14:25

openshift-ci bot added the component/knative Related to knative-plugin label Oct 24, 2025

logonoff reviewed Oct 24, 2025

View reviewed changes

jhadvig approved these changes Oct 24, 2025

View reviewed changes

openshift-ci bot assigned jhadvig Oct 24, 2025

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 24, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2025

Leo6Leo and others added 2 commits October 28, 2025 11:38

Merge remote-tracking branch 'upstream' into leo/ocpbugs/4806/Remove-…

abbb2b4

…static-extensions-from-knative-plugin/main

openshift-ci bot added component/sdk Related to console-plugin-sdk component/topology Related to topology plugin-api-changed Categorizes a PR as containing plugin API changes and removed lgtm Indicates that a PR is ready to be merged. labels Oct 28, 2025

openshift-ci bot assigned spadgett and vojtechszocs Oct 28, 2025

logonoff reviewed Oct 28, 2025

View reviewed changes

Leo6Leo and others added 4 commits October 28, 2025 15:01

Apply suggestions from code review

0dbd7a8

Co-authored-by: logonoff <[email protected]>

fix: fix the review comments from @logonoff

d16dafe

Merge remote-tracking branch 'upstream' into leo/ocpbugs/4806/Remove-…

d28fbd5

…static-extensions-from-knative-plugin/main

logonoff reviewed Nov 3, 2025

View reviewed changes

openshift-ci bot assigned logonoff Nov 3, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025

Implement async resource resolution for dynamic model factories in Da…

726f09e

…taModelProvider

Leo6Leo changed the title ~~CONSOLE-4806: Remove static extensions from knative-plugin~~ [WIP] CONSOLE-4806: Remove static extensions from knative-plugin Nov 12, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025

openshift-ci bot changed the title ~~[WIP] CONSOLE-4806: Remove static extensions from knative-plugin~~ CONSOLE-4806: Remove static extensions from knative-plugin Nov 13, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2025

logonoff approved these changes Nov 13, 2025

View reviewed changes

openshift-ci bot assigned yapei Nov 13, 2025

openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. labels Nov 13, 2025

logonoff mentioned this pull request Nov 13, 2025

CONSOLE-4858: Fix 27 cycles #15723

Merged

yapei reviewed Nov 17, 2025

View reviewed changes

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 18, 2025

CONSOLE-4806: Remove static extensions from knative-plugin #15641

Are you sure you want to change the base?

CONSOLE-4806: Remove static extensions from knative-plugin #15641

Conversation

Leo6Leo commented Oct 24, 2025

Description

Uh oh!

openshift-ci-robot commented Oct 24, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

logonoff Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

logonoff Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

Leo6Leo commented Oct 24, 2025

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Leo6Leo commented Nov 3, 2025

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

logonoff commented Nov 13, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

logonoff commented Nov 13, 2025

Uh oh!

logonoff commented Nov 13, 2025

Uh oh!

openshift-ci bot commented Nov 13, 2025

Uh oh!

logonoff commented Nov 15, 2025

Uh oh!

Leo6Leo commented Nov 17, 2025

Uh oh!

yapei Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

logonoff Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yapei Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

openshift-ci-robot commented Oct 24, 2025 •

edited by openshift-ci bot

Loading

logonoff Oct 30, 2025 •

edited

Loading

logonoff Oct 24, 2025 •

edited

Loading

logonoff commented Nov 13, 2025 •

edited by openshift-ci bot

Loading

yapei Nov 17, 2025 •

edited

Loading

logonoff Nov 17, 2025 •

edited

Loading

yapei Nov 17, 2025 •

edited

Loading