OCPBUGS-57354: block upgrade if a CNI migration is in progress #2760

jluhrsen · 2025-08-01T19:55:15Z

No description provided.

openshift-ci-robot · 2025-08-01T19:55:22Z

@jluhrsen: This pull request references Jira Issue OCPBUGS-57354, which is invalid:

expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.20" instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-57354 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jluhrsen · 2025-08-01T19:57:43Z

/jira refresh

openshift-ci-robot · 2025-08-01T19:57:47Z

@jluhrsen: This pull request references Jira Issue OCPBUGS-57354, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-57354 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jluhrsen · 2025-08-02T16:24:48Z

/retest

jluhrsen · 2025-08-03T06:11:59Z

/retest

jluhrsen · 2025-08-03T16:58:20Z

/retest

jluhrsen · 2025-08-03T16:59:10Z

/jira refresh

openshift-ci-robot · 2025-08-03T16:59:14Z

@jluhrsen: This pull request references Jira Issue OCPBUGS-57354, which is invalid:

expected Jira Issue OCPBUGS-57354 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jluhrsen · 2025-08-03T17:05:35Z

@pliurh , PTAL

jluhrsen · 2025-08-04T17:08:10Z

/jira refresh

openshift-ci-robot · 2025-08-04T17:08:17Z

@jluhrsen: This pull request references Jira Issue OCPBUGS-57354, which is invalid:

expected dependent Jira Issue OCPBUGS-60104 to target a version in 4.17.0, 4.17.z, but it targets "4.17" instead
dependent bug GRPA-4594 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jluhrsen · 2025-08-04T17:08:48Z

/jira refresh

openshift-ci-robot · 2025-08-04T17:08:53Z

@jluhrsen: This pull request references Jira Issue OCPBUGS-57354, which is invalid:

dependent bug GRPA-4594 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jluhrsen · 2025-08-04T17:12:22Z

/jira refresh

openshift-ci-robot · 2025-08-04T17:12:29Z

@jluhrsen: This pull request references Jira Issue OCPBUGS-57354, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.z) matches configured target version for branch (4.16.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-60104 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-60104 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0, 4.17.z
bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pkg/controller/statusmanager/status_manager.go

pliurh · 2025-08-06T02:31:02Z

pkg/controller/statusmanager/status_manager.go

+			)
+		}
+
+		if oc.Spec.DefaultNetwork.Type == operv1.NetworkTypeOpenShiftSDN && migrationInProgress {


I think we shall remove the check oc.Spec.DefaultNetwork.Type == operv1.NetworkTypeOpenShiftSDN. Upgrade shall be blocked when migrationInProgress is true.

jluhrsen · 2025-08-22T21:20:09Z

thanks for the review @pliurh . I think I addressed both of your comments. PTAL

jluhrsen · 2025-08-23T23:31:52Z

/retest

jluhrsen · 2025-08-24T17:49:37Z

/retest

oarribas · 2025-10-02T17:58:25Z

/retest

oarribas · 2025-10-03T07:03:18Z

/retest-required

oarribas · 2025-10-03T09:13:47Z

/retest-required

oarribas · 2025-10-03T15:46:42Z

/retest-required

jluhrsen · 2025-10-04T01:39:09Z

@kyrtapz I think we are good here

oarribas · 2025-10-07T14:49:57Z

/retest-required

pliurh · 2025-10-10T02:14:58Z

/approve
/lgtm

jluhrsen · 2025-10-12T19:45:38Z

/verified by ci

openshift-ci-robot · 2025-10-12T19:45:48Z

@jluhrsen: This PR has been marked as verified by ci.

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pliurh · 2025-10-14T02:40:06Z

/approve

pliurh · 2025-10-14T02:40:15Z

/label backport-risk-assessed

openshift-ci · 2025-10-14T02:40:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jluhrsen, pliurh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pliurh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-10-14T03:36:47Z

/retest-required

Remaining retests: 0 against base HEAD 3c3aece and 2 for PR HEAD b1d50df in total

oarribas · 2025-10-14T12:29:04Z

/retest

openshift-ci · 2025-10-14T16:02:55Z

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	`8421b98`	link	false	`/test e2e-vsphere-ovn-dualstack-primaryv6`
ci/prow/security	`b1d50df`	link	false	`/test security`
ci/prow/e2e-aws-ovn-windows	`b1d50df`	link	true	`/test e2e-aws-ovn-windows`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jluhrsen · 2025-10-14T17:51:41Z

@pliurh the windows job is in horrible state. can you /override it please?

the only place it runs is in CNO so I doubt anyone even knows or cares about it.

jluhrsen mentioned this pull request Aug 1, 2025

OCPBUGS-57354: block upgrade if a CNI migration is in progress #2738

Closed

openshift-ci bot requested review from dougbtv and tssurya August 1, 2025 19:56

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 4, 2025

openshift-ci bot requested a review from anuragthehatter August 4, 2025 17:12

pliurh reviewed Aug 6, 2025

View reviewed changes

pkg/controller/statusmanager/status_manager.go Outdated Show resolved Hide resolved

pliurh reviewed Aug 6, 2025

View reviewed changes

jluhrsen force-pushed the OCPBUGS-57354-release-4.16 branch from 8421b98 to cb8a940 Compare August 22, 2025 21:19

openshift-ci bot assigned pliurh Oct 10, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 12, 2025

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 14, 2025

openshift-ci bot assigned anuragthehatter, asood-rh, barbora137, eurijon, huiran0826, imatza-rh and jechen0648 Oct 14, 2025

openshift-ci bot assigned Meina-rh and mffiedler Oct 14, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2025

OCPBUGS-57354: block upgrade if a CNI migration is in progress #2760

Are you sure you want to change the base?

OCPBUGS-57354: block upgrade if a CNI migration is in progress #2760

Uh oh!

Conversation

jluhrsen commented Aug 1, 2025

Uh oh!

openshift-ci-robot commented Aug 1, 2025

Uh oh!

jluhrsen commented Aug 1, 2025

Uh oh!

openshift-ci-robot commented Aug 1, 2025

Uh oh!

jluhrsen commented Aug 2, 2025

Uh oh!

jluhrsen commented Aug 3, 2025

Uh oh!

jluhrsen commented Aug 3, 2025

Uh oh!

jluhrsen commented Aug 3, 2025

Uh oh!

openshift-ci-robot commented Aug 3, 2025

Uh oh!

jluhrsen commented Aug 3, 2025

Uh oh!

jluhrsen commented Aug 4, 2025

Uh oh!

openshift-ci-robot commented Aug 4, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jluhrsen commented Aug 4, 2025

Uh oh!

openshift-ci-robot commented Aug 4, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jluhrsen commented Aug 4, 2025

Uh oh!

openshift-ci-robot commented Aug 4, 2025

Uh oh!

Uh oh!

pliurh Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

jluhrsen Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

jluhrsen commented Aug 22, 2025

Uh oh!

jluhrsen commented Aug 23, 2025

Uh oh!

jluhrsen commented Aug 24, 2025

Uh oh!

oarribas commented Oct 2, 2025

Uh oh!

oarribas commented Oct 3, 2025

Uh oh!

oarribas commented Oct 3, 2025

Uh oh!

oarribas commented Oct 3, 2025

Uh oh!

jluhrsen commented Oct 4, 2025

Uh oh!

oarribas commented Oct 7, 2025

Uh oh!

pliurh commented Oct 10, 2025

Uh oh!

jluhrsen commented Oct 12, 2025

Uh oh!

openshift-ci-robot commented Oct 12, 2025

Uh oh!

pliurh commented Oct 14, 2025

Uh oh!

pliurh commented Oct 14, 2025

Uh oh!

openshift-ci bot commented Oct 14, 2025

Uh oh!

openshift-ci-robot commented Oct 14, 2025

Uh oh!

oarribas commented Oct 14, 2025

Uh oh!

openshift-ci-robot commented Aug 4, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 4, 2025 •

edited by openshift-ci bot

Loading